Skip to content

Support nested parentheses around subqueries, CTEs, and derived tables #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elianddb merged 6 commits into from
Sep 4, 2026
Merged

Support nested parentheses around subqueries, CTEs, and derived tables #489

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
70f7498
sqlparser: allow nested parentheses around subqueries
elianddb Sep 4, 2026
90c284e
sqlparser: assert unaliased nested subqueries error on missing alias
elianddb Sep 4, 2026
8193dca
sqlparser: allow nested parentheses around subqueries and CTEs using …
elianddb Sep 4, 2026
19f017f
Merge remote-tracking branch 'origin/main' into elian/8058
elianddb Sep 4, 2026
0e397f9
sqlparser: adopt paren_ naming convention for query expression and su…
elianddb Sep 4, 2026
5d5ab29
sqlparser: consolidate issue link comments at block boundary in parse…
elianddb Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions go/vt/sqlparser/parse_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,41 @@ var (
}, {
input: "select a from (select 1 as a from tbl1 union select 2 from tbl2) as t (a, b)",
},
{
// https://github.com/dolthub/dolt/issues/8058
Comment thread
elianddb marked this conversation as resolved.
Outdated
input: "SELECT SUM(found) FROM ((SELECT 2 as found FROM dual)) as all_found",
output: "select SUM(`found`) from (select 2 as `found`) as all_found",
},
{
// https://github.com/dolthub/dolt/issues/8058
input: "SELECT SUM(found) FROM (((SELECT 2 as found FROM dual))) as all_found",
output: "select SUM(`found`) from (select 2 as `found`) as all_found",
},
{
// https://github.com/dolthub/dolt/issues/8058
input: "SELECT EXISTS ((SELECT 1))",
output: "select exists (select 1)",
},
{
// https://github.com/dolthub/dolt/issues/8058
input: "SELECT EXISTS (((SELECT 1)))",
output: "select exists (select 1)",
},
{
// https://github.com/dolthub/dolt/issues/8058
input: "WITH t AS ((SELECT 1)) SELECT * FROM t",
output: "with t as (select 1) select * from t",
},
{
// https://github.com/dolthub/dolt/issues/8058
input: "WITH t AS (((SELECT 1))) SELECT * FROM t",
output: "with t as (select 1) select * from t",
},
{
// https://github.com/dolthub/dolt/issues/8058
input: "select a from ((values (1, 2), ('a', 'b'))) as t (a, b)",
output: "select a from (values row(1, 2), row('a', 'b')) as t (a, b)",
},
{
input: "select a from (values (1, 2), ('a', 'b')) as t (a, b)",
output: "select a from (values row(1, 2), row('a', 'b')) as t (a, b)",
Expand Down Expand Up @@ -6148,6 +6183,18 @@ func TestInvalid(t *testing.T) {
input: "select a from (select * from tbl)",
err: "Every derived table must have its own alias",
},
{
input: "select a from ((select * from tbl))",
err: "Every derived table must have its own alias",
},
{
input: "select a from (((select * from tbl)))",
err: "Every derived table must have its own alias",
},
{
input: "select * from ((values (1, 2)))",
err: "Every derived table must have its own alias",
},
{
input: "select a, b from (select * from tbl) sort by a",
err: "syntax error",
Expand Down
Loading
Loading