Support nested parentheses around subqueries, CTEs, and derived tables - #489
Merged
Conversation
elianddb
changed the title
EXISTS
elianddb
commented
Sep 4, 2026
zachmu
reviewed
Sep 4, 2026
zachmu
left a comment
zachmu
left a comment
Member
There was a problem hiding this comment.
I think this implementation does way too much. This should be a relatively simple targeted rule change that just allows ( and ) to arbitrary levels. Instead it adds a bunch of new functions and rules with bad names. We don't need any of this validation, we just need to allow more sets of parens in certain places.
…MySQL terminology
# Conflicts: # go/vt/sqlparser/sql.go
elianddb
changed the title
EXISTS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paren_query_expressionfor CTEs and derived tablesparen_subqueryforEXISTSPREFER_PARENTHESESprecedence token to disambiguate lookahead on shift/reduce conflicts.Fix Double parentheses ie.
((...))do not parse in Dolt dolt#8058Fix
EXISTS ((subquery))fails to parse, whileIN ((subquery))and scalar((subquery))succeed dolt#11722Block [no-release-notes] enginetest: add regression tests for nested parentheses subqueries go-mysql-server#3806