Repository navigation
Conversation
This was referenced Sep 28, 2026
Datasette 1.0a27 removed CSRF tokens and 1.0a34+ changed action menu markup; drop csrftoken inputs and make the row action test robust. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Fixed 100ms sleeps assumed the job had already processed rows, which flaked on slower CI runners. Also raise the wait_for_job() timeouts from 1s to 5s for the same reason. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
asg017
force-pushed
the
otel/01-datasette-1a41
branch
from
September 28, 2026 20:53
e683481 to
2408a73
Compare
This was referenced Sep 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Claude-generated PR description
Makes the plugin require Datasette 1.0a41 and fixes the test suite against it. The dependency was
datasette>=1.0a21with no upper bound, so fresh installs and CI already resolve to 1.0a41, where 14 of the 20 tests fail.Stack: lint (#63) → 1.0a41 compatibility (this PR) → supervised background tasks (#65) → empty jobs (#66) → telemetry (#67). The base branch is
otel/00-lint.Changes
pyproject.toml:datasette>=1.0a41.Sec-Fetch-Site/Origin.csrftokeninputs fromenrichment.htmlandenrichment_job.html. They still rendered via a legacy shim, but they're dead weight.ds_csrftokencookie or post a token.role="menuitem" tabindex="-1", sotest_row_actionsmatches the link with a regex that ignores its attributes. It still checks the "1 row selected" page.Testing
pytest: 20 passed, both unpinned and with--with datasette==1.0a41.ruffandblack: clean.Sec-Fetch-Site: cross-sitePOST still gets a 403.Release note
Datasette 1.0a39 added a default 2s
execute_writetime limit. It could affect third-party enrichments that do large writes inenrich_batch. There's no code change for it here.🤖 Generated with Claude Code