Repository navigation
Conversation
noqa (behaviour-preserving): DTZ001 naive epoch datetime, RUF012 public _subclasses registry, BLE001 job-loop error logging, TRY002 test enrichment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Sep 28, 2026
Pin ruff so its default rule set is reproducible. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This was referenced Sep 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Claude-generated PR description
First PR in a stack that adds OpenTelemetry support. This one gets
ruff check .andruff format --check .passing, pins that tooling in the repo, and runs it in CI, so every later commit in the stack is lint-clean. It should not change behaviour.Stack: lint (this PR) → 1.0a41 compatibility (#64) → supervised background tasks (#65) → empty jobs (#66) → telemetry (#67)
Changes
ruff --fixfixes:.format()→ f-strings,List/Optional/Union/Tuple→list/X | None/tuple(the project requires Python ≥ 3.10), import sorting, and removing unused imports (secrets,datasette.permissions.PermissionSQL).Optionalmade explicit. The visible case isactor_id: str | None = NoneonEnrichment.enrich_batch/enqueue, which is an annotation-only change.list(genexpr)→ list comprehension in the example enrichments.docs/conf.py.blackreformat (commit 1), then switched from black toruff format(commit 2):ruff==0.16.9and dropsblack. The lint rules are ruff's defaults, which change between releases, so the pin makes them reproducible.[tool.ruff]section.lintCI job that runsruff check .andruff format --check ..Justfilerecipes.ruff formatalso formats the Python examples indocs/developing.md.# noqawhere the fix would change behaviour:DTZ001: the naiveJAN_1_2025_EPOCHdatetimeRUF012: theEnrichment._subclassesregistryBLE001: the job loop'sexcept ExceptionTRY002: a test enrichmentTesting
ruff check .andruff format --check .: clean.pytest: 14 failed / 6 passed. That's the same 14 failures asmain:mainis already broken against Datasette 1.0a41 (CSRF tokens were removed, and the action-menu markup changed). The next PR in the stack fixes them.🤖 Generated with Claude Code