[L1T] Phase2 L1Nano: drop hpsTauTable, and the dead HARVEST step from wf .781/.782 - #51803
Open
artlbv wants to merge 1 commit into
Open
[L1T] Phase2 L1Nano: drop hpsTauTable, and the dead HARVEST step from wf .781/.782#51803artlbv wants to merge 1 commit into
artlbv wants to merge 1 commit into
Conversation
hpsTauTable reads l1tHPSPFTauProducerPuppi, which is no longer part of the L1 menu -- only the non-Puppi l1tHPSPFTauProducer is in the Phase-2 SimL1Emulator sequence. Any workflow running p2L1TablesTask therefore aborts with ProductNotFound for l1t::HPSPFTau. This was already known: addPh2L1Objects excluded the table under the nano_l1_hlt modifier, but workflows such as 29634.781/.782 do not apply that modifier and so still crashed. Remove the table from p2L1TablesTask outright and drop the now-redundant modifier; the EDProducer definition is kept so it can be re-enabled if the collection returns. The other four L1 tau tables (caloTau, nnCaloTau, nnPuppiTau, GTnnTau) are unaffected. With the nano step fixed, wf 29634.781 got as far as HARVESTING and exposed a second, independent problem: L1CompleteWithNano/L1CompleteOnlyNano inherit a HARVESTGlobal step from the HLTTiming75e33 template, but their step2 runs no VALIDATION/DQM sequence and writes only FEVTDEBUGHLT and/or NANOAODSIM, so step2_inDQM.root is never produced and HARVESTING:@hltValidation can only fail with a FileOpenError. Drop the step via a small UpgradeWorkflow subclass. The steps/PU lists are deep-copied so the HLTTiming75e33 template itself is unchanged (wf .75 still harvests). Tested in CMSSW_20_1_0_pre1 (el9_amd64_gcc13): runTheMatrix.py --what upgrade -i all -l 29634.781 now reports "1 1 tests passed, 0 0 failed"; step2 completes 10/10 events with zero exceptions and writes a full 504-branch NanoAOD. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012ZhBBoZkn3gtRtXmW3FYoM
Contributor
|
cms-bot internal usage |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51803/50793
|
Contributor
|
A new Pull Request was created by @artlbv for master. It involves the following packages:
@AdrianoDee, @BenjaminRS, @DickyChant, @antoniovagnerini, @battibass, @cmsbuild, @ftorrresd, @kfjack, @miquork, @quinnanm, @sroychow can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
is this not tested anywhere? |
Contributor
|
test parameters:
|
Contributor
|
@cmsbuild, please test |
Contributor
|
-1 Failed Tests: RelVals Failed RelValsAMD_MI300X Comparison SummarySummary:
AMD_W7900 Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L4 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
Max Memory Comparisons exceeding threshold NVIDIA_L4@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
Max Memory Comparisons exceeding threshold NVIDIA_L40S@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
Max Memory Comparisons exceeding threshold NVIDIA_T4@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
Contributor
|
Hi @artlbv |
Contributor
|
@cmsbuild, please test |
Contributor
|
+1 Size: This PR adds an extra 48KB to repository Comparison SummarySummary:
AMD_MI300X Comparison SummarySummary:
AMD_W7900 Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L4 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
Max Memory Comparisons exceeding threshold NVIDIA_L40S@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
Max Memory Comparisons exceeding threshold NVIDIA_T4@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
This was referenced Sep 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
FYI @RobertJWard @BenjaminRS @quinnanm @mmusich @elenavernazza
Workflows
29634.781/.782(Phase-2 L1 NanoAOD) cannot run. Two independent causes, both reproducible on an unmodified release:hpsTauTablereads a collection that is no longer produced. It readsl1tHPSPFTauProducerPuppi, but only the non-Puppil1tHPSPFTauProduceris in the Phase-2SimL1Emulatorsequence, so any workflow runningp2L1TablesTaskaborts withProductNotFoundforl1t::HPSPFTau.addPh2L1Objectsalready excluded the table under thenano_l1_hltmodifier — with a comment noting the collection is "no longer available in the L1 menu" — but these workflows do not apply that modifier. Remove the table fromp2L1TablesTaskand drop the now-redundant modifier block; theEDProducerdefinition is kept so it can be re-enabled if the collection returns.A HARVESTING step that can never have an input.
L1CompleteWithNano/L1CompleteOnlyNanoinheritHARVESTGlobalfrom theHLTTiming75e33template, but theirstep2runs noVALIDATION/DQMsequence and writes onlyFEVTDEBUGHLT,NANOAODSIM(.782:NANOAODSIM), sostep2_inDQM.rootis never produced andHARVESTING:@hltValidationfails withFileOpenError. Dropped via a smallUpgradeWorkflowsubclass that sets the HARVEST entry toNone. Removing it from thestepslist alone is not sufficient —relval_upgrade.pythen appends the step unsuffixed.steps/PUare deep-copied so the sharedHLTTiming75e33template is not mutated.Expected output changes: the
L1hpsTau_*branches are removed from the Phase-2 L1 NanoAOD — in current workflows they were never actually written, since the table only aborted the job, but they could still appear when running over legacy inputs containing the Puppi producer. The other four L1 tau tables (L1caloTau,L1nnCaloTau,L1nnPuppiTau,L1GTnnTau) are unaffected.29634.781/.782no longer schedule a HARVESTING step;29634.75and theHLTTiming75e33template are unchanged.No dependencies on other PRs or externals.
PR validation:
CMSSW_20_1_0_pre1,el9_amd64_gcc13.runTheMatrix.py --what upgrade -i all -l 29634.781reports1 1 tests passed, 0 0 failed. step2 processes all 10 events with zero exceptions and writes a complete NanoAOD (10 entries, 504 branches) plus theFEVTDEBUGHLToutput. Before this PR the same command reportedStep1-FAILED/Step2-NOTRUN.29634.781/.782no longer show it, while29634.75still shows+HARVESTGlobal_HLT75e33Timing_Run4D110.L1caloTau,L1nnCaloTau,L1nnPuppiTau,L1GTnnTau.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport; targets
master. No backport currently intended.