Skip to content

Remove trimmed tracking configuration for HLT Phase-2 - #51816

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
JanGerritSchulz:jgs_rmTrimmedTracking
Sep 9, 2026
Merged

Remove trimmed tracking configuration for HLT Phase-2#51816
cmsbuild merged 1 commit into
cms-sw:masterfrom
JanGerritSchulz:jgs_rmTrimmedTracking

Conversation

@JanGerritSchulz

Copy link
Copy Markdown
Contributor

PR description:

This PR is removing the trimmed tracking configuration for HLT Phase-2. This includes the procModifier phase2_hlt_vertexTrimming that activates the tracking variant, all its custom HLT module configurations, and the related runTheMatrix workflow.

This tracking option is largely outdated since newer tracking configurations like the current baseline outperform it with respect to timing and physics. Therefore from Tracking POG and HLT Upgrade sides, there is no motivation or need to keep it around any longer. Removing it simplifies maintenance and the intergration of new developments.

PR validation:

I ran a limited amount of tests locally using:

runTheMatrix.py -l ph2_hlt -i all --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

FYI @VourMa @AdrianoDee

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51816/50809

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @JanGerritSchulz for master.

It involves the following packages:

  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (pdmv)
  • HLTrigger/Configuration (hlt)

@AdrianoDee, @DickyChant, @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @kfjack, @mandrenguyen, @miquork, @mmusich, @sroychow can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @fabiocos, @makortel, @missirol, @mmusich, @rovere, @slomeo this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich

mmusich commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51816/50810

@JanGerritSchulz

Copy link
Copy Markdown
Contributor Author

@JanGerritSchulz can you please tidy up also the readme file?

Done! Thanks, I missed that one :-)

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Pull request #51816 was updated. @AdrianoDee, @DickyChant, @Martin-Grunewald, @antoniovagnerini, @cmsbuild, @davidlange6, @fabiocos, @ftenchini, @kfjack, @mandrenguyen, @miquork, @mmusich, @sroychow can you please check and sign again.

@mmusich

mmusich commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

test parameters:

  • enable = hlt_p2_integration
  • workflows = ph2_hlt

@mmusich

mmusich commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

great, this comes right in time for #51817 :)

@mmusich

mmusich commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild, please test

@cmsbuild

cmsbuild commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 88KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-915f3d/55673/summary.html
COMMIT: d4d59a3
CMSSW: CMSSW_20_1_X_2026-09-02-2300/el9_amd64_gcc14
Additional Tests: HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51816/55673/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 60
  • DQMHistoTests: Total histograms compared: 4051507
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4051489
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 59 files compared)
  • Checked 254 log files, 207 edm output root files, 60 DQM output files
  • TriggerResults: no differences found

AMD_MI300X Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 64 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 173739
  • DQMHistoTests: Total failures: 7532
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 166207
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 25 log files, 20 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

AMD_W7900 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 67 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 173739
  • DQMHistoTests: Total failures: 8045
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 165694
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 25 log files, 20 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

NVIDIA_H100 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 75 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 173739
  • DQMHistoTests: Total failures: 8674
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 165065
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 25 log files, 20 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

NVIDIA_L4 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 41 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 173739
  • DQMHistoTests: Total failures: 6927
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 166812
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 25 log files, 20 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

NVIDIA_L40S Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 85 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 173739
  • DQMHistoTests: Total failures: 8859
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 164880
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 25 log files, 20 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

NVIDIA_T4 Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 58 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 173739
  • DQMHistoTests: Total failures: 7126
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 166613
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 25 log files, 20 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

Max Memory Comparisons exceeding threshold NVIDIA_H100

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 37634.7503_TTbar_14TeV+Run4D127_HLTHeterogeneousValid step2 max memory diff 221.8 exceeds +/- 30.0 MiB

Max Memory Comparisons exceeding threshold NVIDIA_L40S

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 37634.7503_TTbar_14TeV+Run4D127_HLTHeterogeneousValid step2 max memory diff 200.4 exceeds +/- 30.0 MiB

Max Memory Comparisons exceeding threshold NVIDIA_T4

@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 37634.7503_TTbar_14TeV+Run4D127_HLTHeterogeneousValid step2 max memory diff -30.7 exceeds +/- 30.0 MiB

@mmusich

mmusich commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

+hlt

  • thanks for the clean-up

@mmusich

mmusich commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@cms-sw/pdmv-l2 kind reminder.

@antoniovagnerini

Copy link
Copy Markdown

+pdmv

@cmsbuild

cmsbuild commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants