Remove no-op if-statement and corresponding TODO from calculateVertexSharedTracks.cc

[JanGerritSchulz]

PR description:

Follow-up on #51577 (comment) and #51709 (comment).

This PR removes a placeholder no-op if statement and the corresponding TODO as it is not really meaningful due to the MiniAOD file content which typically does not even provide all necessary objects to run the given function/association.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51719/50636

[cmsbuild]

A new Pull Request was created by @JanGerritSchulz for master.

It involves the following packages:

• SimTracker/VertexAssociation (simulation)

@civanch, @cmsbuild, @kpedro88, @mdhildreth can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @VinInn, @VourMa, @dgulhan, @elusian, @mmasciov, @mmusich, @mtosi, @rovere, @threus this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

type ngt, bug-fix

[mmusich]

@cmsbuild, please test

[makortel]

Thanks! Could you also remove

#include "DataFormats/PatCandidates/interface/PackedCandidate.h"

from SimTracker/VertexAssociation/src/VertexAssociatorByPositionAndTracks.cc?

[JanGerritSchulz]

Sure, also fixed another comment, while on it 👍

[mmusich]

code-checks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51719/50640

[cmsbuild]

Pull request #51719 was updated. @civanch, @cmsbuild, @kpedro88, @mdhildreth can you please check and sign again.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6234a6/55404/summary.html
COMMIT: d685e13
CMSSW: CMSSW_20_1_X_2026-08-17-1100/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51719/55404/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3591807
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3591789
• DQMHistoTests: Total skipped: 18
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 195 log files, 163 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1