Skip to content

Patch: Remove hltPhase2PixelVertices from DST_HeterogeneousReco - #51627

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
EmanueleCoradin:fix-testHandWrittenPathMatchesTheMenu
Aug 5, 2026
Merged

Patch: Remove hltPhase2PixelVertices from DST_HeterogeneousReco#51627
cmsbuild merged 1 commit into
cms-sw:masterfrom
EmanueleCoradin:fix-testHandWrittenPathMatchesTheMenu

Conversation

@EmanueleCoradin

Copy link
Copy Markdown
Contributor

PR description:

PR #51042 added the hltPhase2PixelVertices to DST_HeterogeneousReco_cfi.py but since it is not a heterogeneous module, it should not be included there.
As a result, it causes failures in the new test_heterogeneousMenu introduced by PR #51583 (logs).

This PR should fix the issue.

@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@EmanueleCoradin
EmanueleCoradin marked this pull request as draft August 5, 2026 10:39
@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51627/50457

  • There are other open Pull requests which might conflict with changes you have proposed:
    • File HLTrigger/Configuration/python/HLT_75e33/paths/DST_HeterogeneousReco_cfi.py modified in PR(s): SoAMultiView #51458

@EmanueleCoradin

Copy link
Copy Markdown
Contributor Author

type bug-fix

@mmusich

mmusich commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

type ngt

@cmsbuild cmsbuild added the ngt label Aug 5, 2026
@mmusich

mmusich commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

test parameters:

  • enable = hlt_p2_integration

@mmusich

mmusich commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@cmsbuild please test

@EmanueleCoradin
EmanueleCoradin marked this pull request as ready for review August 5, 2026 12:10
@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @EmanueleCoradin for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-954d9b/55092/summary.html
COMMIT: 122dd2c
CMSSW: CMSSW_20_1_X_2026-08-05-1100/el9_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51627/55092/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3588770
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3588742
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@mmusich

mmusich commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

+hlt

@mmusich

mmusich commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

urgent

  • to fix IBs

@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants