Skip to content

Add LUT for Kalman algo of KMTF - #2

Merged
cmsbuild merged 1 commit into
cms-data:mainfrom
zhenbinwu:Kalman
Aug 13, 2026
Merged

Add LUT for Kalman algo of KMTF#2
cmsbuild merged 1 commit into
cms-data:mainfrom
zhenbinwu:Kalman

Conversation

@zhenbinwu

Copy link
Copy Markdown

Add a data file from cms-sw/cmssw#51111
Will remove the data file from CMSSW once this is merged. Thanks

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @zhenbinwu for branch main.

@BenjaminRS, @akritkbehera, @cmsbuild, @iarspider, @quinnanm, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@quinnanm

quinnanm commented Aug 5, 2026

Copy link
Copy Markdown

please test

@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64cc2f/55087/summary.html
COMMIT: e16859a
CMSSW: CMSSW_20_1_X_2026-08-04-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-Phase2L1GMT/2/55087/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3588770
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3588745
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@quinnanm

quinnanm commented Aug 5, 2026

Copy link
Copy Markdown

+l1

@smuzaffar

Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51111

This PR contains a new data files needed by cms-sw/cmssw#51111

@cmsbuild

cmsbuild commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64cc2f/55104/summary.html
COMMIT: e16859a
CMSSW: CMSSW_20_1_X_2026-08-05-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-Phase2L1GMT/2/55104/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64cc2f/55104/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64cc2f/55104/git-merge-result

Failed Build

I found compilation error when building:

@@@@ ----> OK EDM Class Transients DataFormatsL1Scouting
>> Checking EDM Class Version for src/DataFormats/MuonDetId/src/classes_def.xml in DataFormatsMuonDetId
@@@@ ----> OK EDM Class Transients DataFormatsL1TCalorimeter
>> Checking EDM Class Version for src/DataFormats/MuonReco/src/classes_def.xml in DataFormatsMuonReco
@@@@ ----> OK EDM Class Transients DataFormatsL1TCalorimeterPhase2
error: class 'l1t::KMTFTrack' has a different checksum for ClassVersion 4. Increment ClassVersion to 5 and assign it to checksum 2306202566
>> Checking EDM Class Version for src/DataFormats/MuonSeed/src/classes_def.xml in DataFormatsMuonSeed
Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/L1TMuonPhase2/src/classes_def.xml.generated with updated ClassVersion
gmake: *** [tmp/el9_amd64_gcc13/edm_checks/libDataFormatsL1TMuonPhase2.so] Error 1
>> Checking EDM Class Version for src/DataFormats/NanoAOD/src/classes_def.xml in DataFormatsNanoAOD
@@@@ ----> OK EDM Class Transients DataFormatsL1TGlobal


@zhenbinwu

Copy link
Copy Markdown
Author

Increment ClassVersion of KMTFTrack in cms-sw/cmssw#51111
Please test again

@quinnanm

quinnanm commented Aug 7, 2026

Copy link
Copy Markdown

please test with cms-sw/cmssw#51111

@cmsbuild

cmsbuild commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64cc2f/55165/summary.html
COMMIT: e16859a
CMSSW: CMSSW_20_1_X_2026-08-07-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-Phase2L1GMT/2/55165/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

  • 2022.0010001DAS Error
  • 2023.0020001DAS Error
  • 2024.0000001DAS Error
Expand to see more relval errors ...

Failed RelVals-INPUT

  • 2022.0000001DAS Error
  • 2022.0000002DAS Error
  • 2022.0010001DAS Error
Expand to see more relval errors ...
  • 2022.0010002
  • 2022.0020001
  • 2022.0020002
  • 2023.0000001
  • 2023.0000002
  • 2023.0010001
  • 2023.0010002
  • 2023.0020001
  • 2023.0020002
  • 2024.0000001
  • 2024.0000002
  • 2024.0010001
  • 2024.0010002
  • 2024.0020001
  • 2024.0020002
  • 2024.0030001
  • 2024.0030002
  • 2024.0040001
  • 2024.0040002
  • 2024.0050001
  • 2024.0050002
  • 2024.0060001
  • 2024.0060002
  • 2024.0070001
  • 2024.0070002
  • 2025.0000001
  • 2025.0000002
  • 2025.0010001
  • 2025.0010002
  • 2025.0020001
  • 2025.0020002

@zhenbinwu

Copy link
Copy Markdown
Author

Exception Message:
edm::FileInPath unable to find file L1Trigger/Phase2L1GMT/data/packedGainLUTs.root anywhere in the search path.

I am confused. packedGainLUTs.root is already in this repo.

@smuzaffar

Copy link
Copy Markdown
Contributor

I am looking in to it

@smuzaffar

Copy link
Copy Markdown
Contributor

please test with cms-sw/cmssw#51111

@cmsbuild

cmsbuild commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-64cc2f/55175/summary.html
COMMIT: e16859a
CMSSW: CMSSW_20_1_X_2026-08-07-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/L1Trigger-Phase2L1GMT/2/55175/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3589140
  • DQMHistoTests: Total failures: 216
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3588906
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@cmsbuild

Copy link
Copy Markdown
Contributor

REMINDER @ftenchini, @sextonkennedy, @mandrenguyen: This PR was tested with cms-sw/cmssw#51111, please check if they should be merged together

@mandrenguyen

Copy link
Copy Markdown

+1

@mandrenguyen

Copy link
Copy Markdown

merge

@cmsbuild
cmsbuild merged commit 563d2c1 into cms-data:main Aug 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants