Improve how some ActivityRegistry signals are emitted

[makortel]

PR description:

This PR improves how ActivityRegistry signals for the "easy cases" listed in #51545 are emitted. It adds a edm::signalslot::SignalSentry helper class to call a given lambda either at succeeded() method (exception from the lambda propagated) or at the destructor (exception from the lambda not propagated).

The overall pattern followed here is

{
  
  auto sentry = edm::signalslot::make_sentry(<lambda for post signal>);
  <emit pre signal>

  <operation itself>

  sentry.succeeded();
}

Creating the sentry for the Post signal first makes the Post signal to be called also if Pre signal throws an exception, and the succeeded() method call allows exceptions from the Post signal (even if we recommend against those) to propagate if there isn't an exception in flight already.

Resolves cms-sw/framework-team#2367

PR validation:

Unit tests pass

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51625/50449

[cmsbuild]

A new Pull Request was created by @makortel for master.

It involves the following packages:

• CondCore/CondHDF5ESSource (db)
• FWCore/Framework (core)
• FWCore/Utilities (core)
• FWIO/RNTupleTempInput (core)
• IOPool/Input (core)

@Alejandro1400, @Dr15Jones, @EltonSh, @JanChyczynski, @arunhep, @cmsbuild, @francescobrivio, @makortel, @perrotta, @smuzaffar can you please review it and eventually sign? Thanks.
@JanChyczynski, @PonIlya, @felicepantaleo, @mmusich, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests RelVals RelVals-INPUT AddOn
Size: This PR adds an extra 124KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fb4e8/55083/summary.html
COMMIT: 9ca3e83
CMSSW: CMSSW_20_1_X_2026-08-04-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51625/55083/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 8 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS
---> test DetectorDescriptionDDCMSTestDriver had ERRORS
---> test GeometryMTDGeometryBuilderTestDriver had ERRORS
and more ...

Failed RelVals

The relvals timed out after 4 hours.

Failed RelVals-INPUT

The relvals timed out after 4 hours.

Failed AddOn Tests

• fastsim

A fatal system signal has occurred: segmentation violation

• fastsim1

----- Begin Fatal Exception 04-Aug-2026 23:14:31 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Calling endJob and endStream
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
----- End Fatal Exception -------------------------------------------------

• fastsim2

----- Begin Fatal Exception 04-Aug-2026 23:14:29 CEST-----------------------
An exception of category 'BadAlloc' occurred while
   [0] Calling endJob and endStream
Exception Message:
A std::bad_alloc exception was thrown.
The job has probably exhausted the virtual memory available to the process.
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

• hlt_mc_Fake
• hlt_mc_Fake
• hlt_mc_Fake1
• hlt_mc_Fake1
• hlt_mc_Fake2
• hlt_mc_Fake2
• hlt_mc_GRun
• hlt_mc_GRun
• hlt_mc_HIon
• hlt_mc_HIon
• hlt_mc_PIon
• hlt_mc_PIon
• hlt_mc_PRef
• hlt_mc_PRef
• hlt_mc_Special
• hlt_mc_Special
• hlt_data_Fake
• hlt_data_Fake
• hlt_data_Fake1
• hlt_data_Fake1
• hlt_data_Fake2
• hlt_data_Fake2
• hlt_data_GRun
• hlt_data_GRun
• hlt_data_HIon
• hlt_data_HIon
• hlt_data_PIon
• hlt_data_PIon
• hlt_data_PRef
• hlt_data_PRef
• hlt_data_Special
• hlt_data_Special

[makortel]

Very interesting failures

[makortel]

Found one mistake, preESModuleSignal_ was emitted twice

[makortel]

@cmsbuild, please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51625/50467

[cmsbuild]

Pull request #51625 was updated. @Alejandro1400, @Dr15Jones, @EltonSh, @JanChyczynski, @arunhep, @cmsbuild, @francescobrivio, @makortel, @perrotta, @smuzaffar can you please check and sign again.

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: UnitTests
Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5fb4e8/55180/summary.html
COMMIT: 71fdefd
CMSSW: CMSSW_20_1_X_2026-08-07-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51625/55180/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed Unit Tests

I found 7 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS
---> test testJetMETCorrectionsType1MET had ERRORS
---> test test_edmPickEvents had ERRORS
and more ...

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 45
• DQMHistoTests: Total histograms compared: 3589140
• DQMHistoTests: Total failures: 16
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3589106
• DQMHistoTests: Total skipped: 18
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
• Checked 195 log files, 163 edm output root files, 45 DQM output files
• TriggerResults: no differences found

[makortel]

Comparison differences are related to #47071

[makortel]

Test failures are known problems or infrastructure related

[makortel]

ignore tests-rejected with ib-failure

[makortel]

+core

[perrotta]

+db

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @ftenchini, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

[mandrenguyen]

+1