Skip to content

Have InputProcessBlock transition have its own Workers - #51661

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:optimizeInputProcess
Aug 13, 2026
Merged

Have InputProcessBlock transition have its own Workers#51661
cmsbuild merged 1 commit into
cms-sw:masterfrom
Dr15Jones:optimizeInputProcess

Conversation

@Dr15Jones

Copy link
Copy Markdown
Contributor

PR description:

PR validation:

Code compiles, framework unit tests pass.

resolves cms-sw/framework-team#2387

@cmsbuild

cmsbuild commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@Dr15Jones

Copy link
Copy Markdown
Contributor Author

hold

wait till #51641 is merged

@cmsbuild cmsbuild added the hold label Aug 10, 2026
@cmsbuild

Copy link
Copy Markdown
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51661/50530

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51661/50531

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request has been put on hold by @Dr15Jones
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @Dr15Jones for master.

It involves the following packages:

  • FWCore/Framework (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 36KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7838c1/55228/summary.html
COMMIT: 8b5359f
CMSSW: CMSSW_20_1_X_2026-08-10-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51661/55228/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

----- Begin Fatal Exception 10-Aug-2026 18:54:37 CEST-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

@makortel

Copy link
Copy Markdown
Contributor

Changes look fine

@Dr15Jones

Copy link
Copy Markdown
Contributor Author

Unhold

@cmsbuild cmsbuild removed the hold label Aug 13, 2026
@Dr15Jones

Copy link
Copy Markdown
Contributor Author

Please test

@Dr15Jones
Dr15Jones changed the base branch from master to CMSSW_20_1_X August 13, 2026 13:21
@Dr15Jones
Dr15Jones changed the base branch from CMSSW_20_1_X to master August 13, 2026 13:21
@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7838c1/55311/summary.html
COMMIT: 8b5359f
CMSSW: CMSSW_20_1_X_2026-08-13-0800/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51661/55311/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3435544
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3435526
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@makortel

Copy link
Copy Markdown
Contributor

+core

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 9cc0f57 into cms-sw:master Aug 13, 2026
16 of 17 checks passed
@Dr15Jones
Dr15Jones deleted the optimizeInputProcess branch August 13, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Have InputProcessBlock transition have its own Workers

4 participants