Skip to content

Regenerate DQMServices/Core protobuf gencode for protobuf 6.31.1 - #51507

Open
akritkbehera wants to merge 3 commits into
cms-sw:masterfrom
akritkbehera:regenerate_protobuf_objects
Open

Regenerate DQMServices/Core protobuf gencode for protobuf 6.31.1#51507
akritkbehera wants to merge 3 commits into
cms-sw:masterfrom
akritkbehera:regenerate_protobuf_objects

Conversation

@akritkbehera

@akritkbehera akritkbehera commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Regenerates the checked-in protobuf gencode in DQMServices/Core with protoc 6.31.1, as required by the protobuf update in cms-sw/cmsdist#10724 (protobuf 3.21.9 → 6.31.1, abseil-cpp, grpc 1.35.0 → 1.82.0, TensorFlow 2.21.0).
Files regenerated:

  • DQMServices/Core/interface/ROOTFilePB.pb.h
  • DQMServices/Core/src/ROOTFilePB.pb.cc

@cmsbuild cmsbuild added this to the CMSSW_20_1_X milestone Jul 16, 2026
@cmsbuild

cmsbuild commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@akritkbehera akritkbehera mentioned this pull request Jul 16, 2026
Closed
@cmsbuild

cmsbuild commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51507/50216

ERROR: Build errors found during clang-tidy run.

src/DQMServices/Core/src/ROOTFilePB.pb.h:14:10: error: 'google/protobuf/runtime_version.h' file not found [clang-diagnostic-error]
   14 | #include "google/protobuf/runtime_version.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/DQMServices/Core/src/ROOTFilePB.pb.h:163:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@smuzaffar

smuzaffar commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

@akritkbehera , please move the header file should go in to the interface directory DQMServices/Core/interface and update the cc file to include it from there

@akritkbehera
akritkbehera force-pushed the regenerate_protobuf_objects branch from d2f1eb8 to c71bec9 Compare July 16, 2026 20:55
@cmsbuild

cmsbuild commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51507/50229

ERROR: Build errors found during clang-tidy run.

src/DQMServices/Core/interface/ROOTFilePB.pb.h:14:10: error: 'google/protobuf/runtime_version.h' file not found [clang-diagnostic-error]
   14 | #include "google/protobuf/runtime_version.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/DQMServices/Core/interface/ROOTFilePB.pb.h:163:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@cmsbuild

cmsbuild commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51507/50238

ERROR: Build errors found during clang-tidy run.

src/DQMServices/Core/interface/ROOTFilePB.pb.h:14:10: error: 'google/protobuf/runtime_version.h' file not found [clang-diagnostic-error]
   14 | #include "google/protobuf/runtime_version.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/DQMServices/Core/interface/ROOTFilePB.pb.h:163:8: warning: annotate this function with 'override' or (rarely) 'final' [modernize-use-override]
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

@akritkbehera akritkbehera changed the title [DO NOT MERGE] Testing updated externals EIGEN/TENSORFLOW/ACTS [DO NOT MERGE] Regenerate DQMServices/Core protobuf gencode for protobuf 6.31.1 Jul 28, 2026
@akritkbehera

akritkbehera commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

code-checks with cms.week0.PR_5e1c2724/100.0-0a3aa3076c92a13d36c78c9e585d52d3

@cmsbuild

cmsbuild commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51507/50337

@cmsbuild

cmsbuild commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @akritkbehera for master.

It involves the following packages:

  • DQMServices/Core (dqm)
  • PhysicsTools/TensorFlowAOT (ml)

@cmsbuild, @ctarricone, @gabrielmscampos, @hjkwon260, @rseidita, @valsdav, @y19y19 can you please review it and eventually sign? Thanks.
@barvic, @makortel, @riga this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@akritkbehera

akritkbehera commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Please test

@akritkbehera

akritkbehera commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

Please abort

@akritkbehera

akritkbehera commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

please test with cms-sw/cmsdist#10724 using full cmssw

@akritkbehera akritkbehera changed the title [DO NOT MERGE] Regenerate DQMServices/Core protobuf gencode for protobuf 6.31.1 Regenerate DQMServices/Core protobuf gencode for protobuf 6.31.1 Jul 28, 2026
@akritkbehera akritkbehera mentioned this pull request Jul 28, 2026
Closed
@cmsbuild

cmsbuild commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a9034e/54958/summary.html
COMMIT: e5b3493
CMSSW: CMSSW_20_1_X_2026-07-27-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51507/54958/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 149 lines to the logs
  • Reco comparison results: 16320 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3588680
  • DQMHistoTests: Total failures: 15623
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 3573027
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.032 KiB( 44 files compared)
  • DQMHistoSizes: changed ( 2024.0020001 ): -0.004 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2024.0030001 ): 0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 2025.0000002 ): 0.020 KiB JetMET/SUSYDQM
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 21 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...
  • Error: Workflow 2025.0000002_RunZeroBias2025B_10k step3 max memory diff 46.0 exceeds +/- 30.0 MiB
  • Error: Workflow 2025.0000002_RunZeroBias2025B_10k step2 max memory diff 54.2 exceeds +/- 30.0 MiB
  • Error: Workflow 2025.0010001_RunJetMET02025C_10k step3 max memory diff 42.1 exceeds +/- 30.0 MiB
  • Error: Workflow 2025.0010001_RunJetMET02025C_10k step2 max memory diff 37.5 exceeds +/- 30.0 MiB
  • Error: Workflow 18434.0_TTbar_14TeV+2026 step2 max memory diff 52.5 exceeds +/- 30.0 MiB
  • Error: Workflow 18434.0_TTbar_14TeV+2026 step3 max memory diff 42.7 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.0_TTbar_14TeV+Run4D121 step3 max memory diff 42.2 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.0_TTbar_14TeV+Run4D121 step5 max memory diff 44.7 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.0_TTbar_14TeV+Run4D121 step2 max memory diff 44.1 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.75_TTbar_14TeV+Run4D121_HLT75e33Timing step2 max memory diff 49.4 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.911_TTbar_14TeV+Run4D121_DD4hep step2 max memory diff 44.0 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.911_TTbar_14TeV+Run4D121_DD4hep step3 max memory diff 42.3 exceeds +/- 30.0 MiB
  • Error: Workflow 34434.911_TTbar_14TeV+Run4D121_DD4hep step5 max memory diff 44.7 exceeds +/- 30.0 MiB
  • Error: Workflow 34496.0_CloseByPGun_CE_E_Front_120um+Run4D121 step2 max memory diff 43.3 exceeds +/- 30.0 MiB
  • Error: Workflow 34496.0_CloseByPGun_CE_E_Front_120um+Run4D121 step3 max memory diff 41.9 exceeds +/- 30.0 MiB
  • Error: Workflow 34496.0_CloseByPGun_CE_E_Front_120um+Run4D121 step5 max memory diff 44.6 exceeds +/- 30.0 MiB
  • Error: Workflow 34500.0_CloseByPGun_CE_H_Coarse_Scint+Run4D121 step2 max memory diff 43.4 exceeds +/- 30.0 MiB
  • Error: Workflow 34500.0_CloseByPGun_CE_H_Coarse_Scint+Run4D121 step5 max memory diff 44.6 exceeds +/- 30.0 MiB
  • Error: Workflow 34500.0_CloseByPGun_CE_H_Coarse_Scint+Run4D121 step3 max memory diff 41.9 exceeds +/- 30.0 MiB
  • Error: Workflow 34634.0_TTbar_14TeV+Run4D121PU step2 max memory diff 39.9 exceeds +/- 30.0 MiB
  • Error: Workflow 34634.0_TTbar_14TeV+Run4D121PU step3 max memory diff 42.4 exceeds +/- 30.0 MiB

@akritkbehera

akritkbehera commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

yay!

@akritkbehera

akritkbehera commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild hold

@cmsbuild

cmsbuild commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Pull request has been put on hold by @akritkbehera
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jul 28, 2026
@cmsbuild cmsbuild mentioned this pull request Aug 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

code-checks-approved dqm-pending hold ml-pending orp-pending pending-signatures requires-external tests-approved

Projects

None yet

Milestone

CMSSW_20_1_X

Development

Successfully merging this pull request may close these issues.

4 participants

@akritkbehera @cmsbuild @smuzaffar @raoatifshad