Add premixing to development ECAL Phase 2 simulation - 200X - #51436
Conversation
|
A new Pull Request was created by @thomreis for CMSSW_20_0_X. It involves the following packages:
@AdrianoDee, @BenjaminRS, @DickyChant, @Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @jfernan2, @kfjack, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @quinnanm, @srimanob, @sroychow can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
|
cms-bot internal usage |
|
type ecal |
|
backport of #51358 |
|
please test |
|
+1 Size: This PR adds an extra 48KB to repository Comparison SummarySummary:
|
|
please test |
|
+1 Size: This PR adds an extra 48KB to repository Comparison SummarySummary:
|
|
-1 Failed Tests: RelVals Failed RelVals |
|
I think the exception happens because the /RelValMinBias_14TeV/CMSSW_16_0_0_pre2-150X_mcRun4_realistic_v1_STD_RegeneratedGS_Run4D121_noPU-v1/GEN-SIM sample for the PU is not compatible with 20_0_X. It's not quite clear to me why that one is picked up by the workflow. |
|
Indeed, for the |
34634.0 also fails with the same exception on |
|
Hi @thomreis, Should we ignore the failures for now, or are you planning to look into them? |
|
I've opened #51462 to fix this. But for the moment I'd just ignore the failures given in master everything is fine and re-run the tests without the new wfs. |
|
test parameters: |
|
please test |
|
+pdmv |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_20_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
I wouldn't use the #51462 for testing just because there could be conflicts with this. |
|
+1 Size: This PR adds an extra 16KB to repository Comparison SummarySummary:
|
|
+1 |
PR description:
This adds the premixing capability to the ECAL Phase 2 simulation. In addition to the already existing premixing case in the
EcalLiteDTUCoder, the implementation follows the legacy one and adds theEcalSignalGeneratorPh2class and the newPreMixingEcalPh2Workerworker plugin.A dedicated upgrade ECAL development workflow (*.61299) with the ECAL simulation development on Alpaka (same as *.612 WFs) and premixing stage 1 + stage 2 is added for testing and further development of the premixing code. All configuration changes are activated by the
phase2_ecal_develera andpremix_stage2modifier.The ECAL Phase 2 TP emulation was added to the new premixing workflow and the ECAL development workflows (.61, .612) as well.
No changes are expected for the default Phase 2 simulation and premixing.
PR validation:
Passes the newly created 34634.61299 workflow and the existing 34634.612 workflow.
Backport of #51358 to be used for special productions in the next Phase 2 MC campaign.