Skip to content

Add premixing to development ECAL Phase 2 simulation - 200X - #51436

Merged
cmsbuild merged 4 commits into
cms-sw:CMSSW_20_0_Xfrom
thomreis:ecal-phase2-devel-premix-200x
Jul 10, 2026
Merged

Add premixing to development ECAL Phase 2 simulation - 200X#51436
cmsbuild merged 4 commits into
cms-sw:CMSSW_20_0_Xfrom
thomreis:ecal-phase2-devel-premix-200x

Conversation

@thomreis

@thomreis thomreis commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

PR description:

This adds the premixing capability to the ECAL Phase 2 simulation. In addition to the already existing premixing case in the EcalLiteDTUCoder , the implementation follows the legacy one and adds the EcalSignalGeneratorPh2 class and the new PreMixingEcalPh2Worker worker plugin.

A dedicated upgrade ECAL development workflow (*.61299) with the ECAL simulation development on Alpaka (same as *.612 WFs) and premixing stage 1 + stage 2 is added for testing and further development of the premixing code. All configuration changes are activated by the phase2_ecal_devel era and premix_stage2 modifier.

The ECAL Phase 2 TP emulation was added to the new premixing workflow and the ECAL development workflows (.61, .612) as well.

No changes are expected for the default Phase 2 simulation and premixing.

PR validation:

Passes the newly created 34634.61299 workflow and the existing 34634.612 workflow.

Backport of #51358 to be used for special productions in the next Phase 2 MC campaign.

@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @thomreis for CMSSW_20_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv)
  • RecoLocalCalo/EcalRecProducers (reconstruction)
  • SimCalorimetry/Configuration (simulation)
  • SimCalorimetry/EcalEBTrigPrimProducers (l1)
  • SimCalorimetry/EcalSimAlgos (simulation)
  • SimCalorimetry/EcalSimProducers (simulation)
  • SimGeneral/PreMixingModule (simulation)

@AdrianoDee, @BenjaminRS, @DickyChant, @Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @jfernan2, @kfjack, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @quinnanm, @srimanob, @sroychow can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @apsallid, @argiro, @denizsun, @fabiocos, @makortel, @martinamalberti, @missirol, @mmusich, @rchatter, @rovere, @salimcerci, @sameasy, @slomeo, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@thomreis

thomreis commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

type ecal

@cmsbuild cmsbuild added the ecal label Jul 7, 2026
@thomreis

thomreis commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

backport of #51358

@thomreis

thomreis commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35eac0/54575/summary.html
COMMIT: a68b2a3
CMSSW: CMSSW_20_0_X_2026-07-07-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51436/54575/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3248390
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248367
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@quinnanm

quinnanm commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

cmsbuild commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35eac0/54579/summary.html
COMMIT: a68b2a3
CMSSW: CMSSW_20_0_X_2026-07-07-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51436/54579/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3248390
  • DQMHistoTests: Total failures: 22
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248350
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@cmsbuild

cmsbuild commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35eac0/54655/summary.html
COMMIT: a68b2a3
CMSSW: CMSSW_20_0_X_2026-07-09-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51436/54655/install.sh to create a dev area with all the needed externals and cmssw changes.

Failed RelVals

----- Begin Fatal Exception 10-Jul-2026 01:28:06 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  GenEventInfoProduct
  GenFilterInfo
  GenLumiInfoHeader
  GenLumiInfoProduct
  GenRunInfoProduct
  edm::HepMCProduct
  edm::Wrapper<GenEventInfoProduct>
  edm::Wrapper<GenFilterInfo>
  edm::Wrapper<GenLumiInfoHeader>
  edm::Wrapper<GenLumiInfoProduct>
  edm::Wrapper<GenRunInfoProduct>
  edm::Wrapper<edm::HepMCProduct>
  edm::Wrapper<std::vector<PCaloHit> >
  edm::Wrapper<std::vector<PSimHit> >
  edm::Wrapper<std::vector<SimTrack> >
  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<PCaloHit>
  std::vector<PSimHit>
  std::vector<SimTrack>
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  GenEventInfoProduct (read from input)
  GenFilterInfo (read from input)
  GenLumiInfoHeader (read from input)
  GenLumiInfoProduct (read from input)
  GenRunInfoProduct (read from input)
  edm::HepMCProduct (read from input)
  std::vector<PCaloHit> (read from input)
  std::vector<PSimHit> (read from input)
  std::vector<SimTrack> (read from input)
  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  GenEventInfoProduct_generator__SIM.
  GenFilterInfo_genFilterEfficiencyProducer__SIM.
  GenLumiInfoHeader_generator__SIM.
  GenLumiInfoProduct_generator__SIM.
  GenRunInfoProduct_generator__SIM.
  PCaloHits_g4SimHits_CalibrationHGCHitsEE_SIM.
  PCaloHits_g4SimHits_CalibrationHGCHitsHEback_SIM.
  PCaloHits_g4SimHits_CalibrationHGCHitsHEfront_SIM.
  PCaloHits_g4SimHits_CaloHitsTk_SIM.
  PCaloHits_g4SimHits_EcalHitsEB_SIM.
  PCaloHits_g4SimHits_HFNoseHits_SIM.
  PCaloHits_g4SimHits_HGCHitsEE_SIM.
  PCaloHits_g4SimHits_HGCHitsHEback_SIM.
  PCaloHits_g4SimHits_HGCHitsHEfront_SIM.
  PCaloHits_g4SimHits_HcalHits_SIM.
  PCaloHits_g4SimHits_ZDCHITS_SIM.
  PSimHits_g4SimHits_BCM1FHits_SIM.
  PSimHits_g4SimHits_BHMHits_SIM.
  PSimHits_g4SimHits_CTPPSPixelHits_SIM.
  PSimHits_g4SimHits_CTPPSTimingHits_SIM.
  PSimHits_g4SimHits_FastTimerHitsBarrel_SIM.
  PSimHits_g4SimHits_FastTimerHitsEndcap_SIM.
  PSimHits_g4SimHits_HFNoseHits_SIM.
  PSimHits_g4SimHits_MuonCSCHits_SIM.
  PSimHits_g4SimHits_MuonDTHits_SIM.
  PSimHits_g4SimHits_MuonGEMHits_SIM.
  PSimHits_g4SimHits_MuonME0Hits_SIM.
  PSimHits_g4SimHits_MuonRPCHits_SIM.
  PSimHits_g4SimHits_PLTHits_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelBarrelHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelBarrelLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelEndcapHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelEndcapLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTECHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTECLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIBHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIBLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIDHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIDLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTOBHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTOBLowTof_SIM.
  SimTracks_g4SimHits__SIM.
  edmHepMCProduct_generatorSmeared__SIM.
  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 10-Jul-2026 01:28:06 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  GenEventInfoProduct
  GenFilterInfo
  GenLumiInfoHeader
  GenLumiInfoProduct
  GenRunInfoProduct
  edm::HepMCProduct
  edm::Wrapper<GenEventInfoProduct>
  edm::Wrapper<GenFilterInfo>
  edm::Wrapper<GenLumiInfoHeader>
  edm::Wrapper<GenLumiInfoProduct>
  edm::Wrapper<GenRunInfoProduct>
  edm::Wrapper<edm::HepMCProduct>
  edm::Wrapper<std::vector<PCaloHit> >
  edm::Wrapper<std::vector<PSimHit> >
  edm::Wrapper<std::vector<SimTrack> >
  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<PCaloHit>
  std::vector<PSimHit>
  std::vector<SimTrack>
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  GenEventInfoProduct (read from input)
  GenFilterInfo (read from input)
  GenLumiInfoHeader (read from input)
  GenLumiInfoProduct (read from input)
  GenRunInfoProduct (read from input)
  edm::HepMCProduct (read from input)
  std::vector<PCaloHit> (read from input)
  std::vector<PSimHit> (read from input)
  std::vector<SimTrack> (read from input)
  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  GenEventInfoProduct_generator__SIM.
  GenFilterInfo_genFilterEfficiencyProducer__SIM.
  GenLumiInfoHeader_generator__SIM.
  GenLumiInfoProduct_generator__SIM.
  GenRunInfoProduct_generator__SIM.
  PCaloHits_g4SimHits_CalibrationHGCHitsEE_SIM.
  PCaloHits_g4SimHits_CalibrationHGCHitsHEback_SIM.
  PCaloHits_g4SimHits_CalibrationHGCHitsHEfront_SIM.
  PCaloHits_g4SimHits_CaloHitsTk_SIM.
  PCaloHits_g4SimHits_EcalHitsEB_SIM.
  PCaloHits_g4SimHits_HFNoseHits_SIM.
  PCaloHits_g4SimHits_HGCHitsEE_SIM.
  PCaloHits_g4SimHits_HGCHitsHEback_SIM.
  PCaloHits_g4SimHits_HGCHitsHEfront_SIM.
  PCaloHits_g4SimHits_HcalHits_SIM.
  PCaloHits_g4SimHits_ZDCHITS_SIM.
  PSimHits_g4SimHits_BCM1FHits_SIM.
  PSimHits_g4SimHits_BHMHits_SIM.
  PSimHits_g4SimHits_CTPPSPixelHits_SIM.
  PSimHits_g4SimHits_CTPPSTimingHits_SIM.
  PSimHits_g4SimHits_FastTimerHitsBarrel_SIM.
  PSimHits_g4SimHits_FastTimerHitsEndcap_SIM.
  PSimHits_g4SimHits_HFNoseHits_SIM.
  PSimHits_g4SimHits_MuonCSCHits_SIM.
  PSimHits_g4SimHits_MuonDTHits_SIM.
  PSimHits_g4SimHits_MuonGEMHits_SIM.
  PSimHits_g4SimHits_MuonME0Hits_SIM.
  PSimHits_g4SimHits_MuonRPCHits_SIM.
  PSimHits_g4SimHits_PLTHits_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelBarrelHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelBarrelLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelEndcapHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelEndcapLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTECHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTECLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIBHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIBLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIDHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIDLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTOBHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTOBLowTof_SIM.
  SimTracks_g4SimHits__SIM.
  edmHepMCProduct_generatorSmeared__SIM.
  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 10-Jul-2026 01:28:06 CEST-----------------------
An exception of category 'DictionaryNotFound' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling ProductRegistry::initializeLookupTables
Exception Message:
No data dictionary found for the following classes:

  GenEventInfoProduct
  GenFilterInfo
  GenLumiInfoHeader
  GenLumiInfoProduct
  GenRunInfoProduct
  edm::HepMCProduct
  edm::Wrapper<GenEventInfoProduct>
  edm::Wrapper<GenFilterInfo>
  edm::Wrapper<GenLumiInfoHeader>
  edm::Wrapper<GenLumiInfoProduct>
  edm::Wrapper<GenRunInfoProduct>
  edm::Wrapper<edm::HepMCProduct>
  edm::Wrapper<std::vector<PCaloHit> >
  edm::Wrapper<std::vector<PSimHit> >
  edm::Wrapper<std::vector<SimTrack> >
  edm::Wrapper<std::vector<reco::GenMET> >
  std::vector<PCaloHit>
  std::vector<PSimHit>
  std::vector<SimTrack>
  std::vector<reco::GenMET>

Most likely each dictionary was never generated, but it may
be that it was generated in the wrong package. Please add
(or move) the specification '<class name="whatever"/>' to
the appropriate classes_def.xml file along with any other
information needed there. For example, if this class has any
transient members, you need to specify them in classes_def.xml.
Also include the class header in classes.h

A type listed above might or might not be the same as a
type stored in the Event (or Lumi or Run). Instead it might
be the type of a data member, base class, wrapped type, or
other object needed by a stored type. Below is some additional
information which lists the stored types associated with the
types whose dictionaries were not found:

  GenEventInfoProduct (read from input)
  GenFilterInfo (read from input)
  GenLumiInfoHeader (read from input)
  GenLumiInfoProduct (read from input)
  GenRunInfoProduct (read from input)
  edm::HepMCProduct (read from input)
  std::vector<PCaloHit> (read from input)
  std::vector<PSimHit> (read from input)
  std::vector<SimTrack> (read from input)
  std::vector<reco::GenMET> (read from input)

Missing dictionaries are associated with these branch names:

  GenEventInfoProduct_generator__SIM.
  GenFilterInfo_genFilterEfficiencyProducer__SIM.
  GenLumiInfoHeader_generator__SIM.
  GenLumiInfoProduct_generator__SIM.
  GenRunInfoProduct_generator__SIM.
  PCaloHits_g4SimHits_CalibrationHGCHitsEE_SIM.
  PCaloHits_g4SimHits_CalibrationHGCHitsHEback_SIM.
  PCaloHits_g4SimHits_CalibrationHGCHitsHEfront_SIM.
  PCaloHits_g4SimHits_CaloHitsTk_SIM.
  PCaloHits_g4SimHits_EcalHitsEB_SIM.
  PCaloHits_g4SimHits_HFNoseHits_SIM.
  PCaloHits_g4SimHits_HGCHitsEE_SIM.
  PCaloHits_g4SimHits_HGCHitsHEback_SIM.
  PCaloHits_g4SimHits_HGCHitsHEfront_SIM.
  PCaloHits_g4SimHits_HcalHits_SIM.
  PCaloHits_g4SimHits_ZDCHITS_SIM.
  PSimHits_g4SimHits_BCM1FHits_SIM.
  PSimHits_g4SimHits_BHMHits_SIM.
  PSimHits_g4SimHits_CTPPSPixelHits_SIM.
  PSimHits_g4SimHits_CTPPSTimingHits_SIM.
  PSimHits_g4SimHits_FastTimerHitsBarrel_SIM.
  PSimHits_g4SimHits_FastTimerHitsEndcap_SIM.
  PSimHits_g4SimHits_HFNoseHits_SIM.
  PSimHits_g4SimHits_MuonCSCHits_SIM.
  PSimHits_g4SimHits_MuonDTHits_SIM.
  PSimHits_g4SimHits_MuonGEMHits_SIM.
  PSimHits_g4SimHits_MuonME0Hits_SIM.
  PSimHits_g4SimHits_MuonRPCHits_SIM.
  PSimHits_g4SimHits_PLTHits_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelBarrelHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelBarrelLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelEndcapHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsPixelEndcapLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTECHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTECLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIBHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIBLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIDHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTIDLowTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTOBHighTof_SIM.
  PSimHits_g4SimHits_TrackerHitsTOBLowTof_SIM.
  SimTracks_g4SimHits__SIM.
  edmHepMCProduct_generatorSmeared__SIM.
  recoGenMETs_genMetCalo__SIM.
  recoGenMETs_genMetTrue__SIM.

If you do not need these branches and they are not produced
in the current process, an alternate solution to adding
dictionaries is to drop these branches on input using the
inputCommands parameter of the PoolSource.
----- End Fatal Exception -------------------------------------------------

@thomreis

Copy link
Copy Markdown
Contributor Author

I think the exception happens because the /RelValMinBias_14TeV/CMSSW_16_0_0_pre2-150X_mcRun4_realistic_v1_STD_RegeneratedGS_Run4D121_noPU-v1/GEN-SIM sample for the PU is not compatible with 20_0_X. It's not quite clear to me why that one is picked up by the workflow.

@thomreis

Copy link
Copy Markdown
Contributor Author

Indeed, for the CMSSW_20_0_X_2026-07-09-1100 tag this is the PU input used. https://github.com/cms-sw/cmssw/blob/CMSSW_20_0_X_2026-07-09-1100/Configuration/PyReleaseValidation/python/relval_steps.py#L4705
It seems 06604ee was not backported to 20_0_X.
Does any PU workflow (e.g. 34634.0) work?

@thomreis

thomreis commented Jul 10, 2026

Copy link
Copy Markdown
Contributor Author

Does any PU workflow (e.g. 34634.0) work?

34634.0 also fails with the same exception on CMSSW_20_0_X_2026-07-09-1100.

@Moanwar

Moanwar commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Hi @thomreis, Should we ignore the failures for now, or are you planning to look into them?

@AdrianoDee

Copy link
Copy Markdown
Contributor

I've opened #51462 to fix this. But for the moment I'd just ignore the failures given in master everything is fine and re-run the tests without the new wfs.

@AdrianoDee

Copy link
Copy Markdown
Contributor

test parameters:

@AdrianoDee

Copy link
Copy Markdown
Contributor

please test

@AdrianoDee

Copy link
Copy Markdown
Contributor

+pdmv

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_20_0_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@AdrianoDee

Copy link
Copy Markdown
Contributor

I wouldn't use the #51462 for testing just because there could be conflicts with this.

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35eac0/54661/summary.html
COMMIT: a68b2a3
CMSSW: CMSSW_20_0_X_2026-07-09-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51436/54661/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3248666
  • DQMHistoTests: Total failures: 75
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248573
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit c4abc8e into cms-sw:CMSSW_20_0_X Jul 10, 2026
9 of 11 checks passed
@thomreis
thomreis deleted the ecal-phase2-devel-premix-200x branch July 12, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants