Add premixing to development ECAL Phase 2 simulation - 200X - #51402
Closed
thomreis wants to merge 447 commits into
Closed
Add premixing to development ECAL Phase 2 simulation - 200X#51402thomreis wants to merge 447 commits into
thomreis wants to merge 447 commits into
Conversation
CUDA 13 removes some deprecated fields from cudaDeviceProp, and replaces most of them with direct calls to cudaDeviceGetAttribute. See https://developer.nvidia.com/blog/whats-new-and-important-in-cuda-toolkit-13-0/#changes_to_cudadeviceprop.
Update CUDAService for CUDA 13.x
MTD Geometry: clean compiler warnings
…ceConcurrent Mark XMLIdealGeometryESSource as concurrent capable
Phase2-hgx367A Add the changes suggested by Vadim with one example SimG4CMS/Calo/test/python/runHGCalColdbox_cfg.py
[WarningFix]:CalibCalorimetry/EcalTrivialCondModules-Check fgets() re…
PF validation on-the-fly update, MLPF support
Implement MIP Timing Detector reconstruction sequence for Phase-2 HLT
Validated the full pyTICL suite against the latest CMSSW_20_1_X IB (2026-06-27-1100, ~290 commits past the CMSSW_20_0_0_pre1 base). 8/9 tests were unchanged; the only drift the suite detected was in the HLT menu: hltPfTICL's MTD-timing maps moved from the offline tofPID / mtdTrackQualityMVA to the hlt-prefixed hltTofPID / hltMtdTrackQualityMVA sources. Update hlt_pf_defaults() to emit the hlt-prefixed timing maps (the corrected HLT config), and allowlist these external service inputs in the HLT test so a per-release prefix difference is reported as drift rather than a hard plumbing failure. The full suite (9 tests) now passes on both CMSSW_20_0_0_pre1 and the CMSSW_20_1_X IB.
Removed use of bare pointers in favor of stack variables or std::unique_ptr.
New Inputs For Run4 D121 Workflows
…n to consider/not consider modules where there are no SimHits. A new configuration parameter has been introduced for this purpose
…timing re-activate Phase2 HLT timing script, using samples produced in `CMSSW_20_0_0_pre1`
…MSSW_20_1_X Fix TICLDumper Configuration
…170X Adding `skipEvents` option to `cmsDriver`
Contributor
|
+simulation It is not clear to me that the backport is needed. |
…ventOfHits fix bug in `hltMkFitEventOfHits`, do not use the offline beamspot at HLT
fix for UBSAN build errors, GCC constexpr incompatibility
…dFormat_20260622 [MTD]: BTL readout mapping - first implementation in CondFormats
Contributor
|
+1 |
Contributor
Author
Apart from the premixing, which according to my understanding is not going to be used for the next Phase 2 MC campaign, this PR also adds the TP emulation to the ECAL Phase 2 development workflows that we would like to use as basis of some sample productions. |
pyTICL configuration framework for TICL
…NgtScouting Add `passThrough` option to `RecoTrackSelectorBase` for `ngtScouting` HLT tracks
…OD_CMSSW_20_1_X Add HGCAL/TICL NanoAOD for offline
…el-clustering-and-ca Make GPU pixel clustering and CA fishbone reproducible
…InNano_v2 [NGT] first implementation of `TrigObjP4FlatTableProducer`
…derSupport Remove support for non-concurrent EventSetupRecordIntervalFinders
cmsbuild
added
simulation-pending
tests-pending
and removed
simulation-approved
tests-approved
labels
Contributor
|
Pull request #51402 was updated. @AdrianoDee, @BenjaminRS, @DickyChant, @antoniovagnerini, @civanch, @cmsbuild, @kfjack, @kpedro88, @mdhildreth, @miquork, @quinnanm, @sroychow can you please check and sign again. |
thomreis
force-pushed
the
ecal-phase2-devel-premix
branch
from
July 7, 2026 17:05
a68b2a3 to
1e75350
Compare
Contributor
|
This PR contains too many commits (447 >= 240) and will not be processed. |
Contributor
Author
|
Since the master PR had to be rebased this PR is closed in favour of #51436. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description:
This adds the premixing capability to the ECAL Phase 2 simulation. In addition to the already existing premixing case in the
EcalLiteDTUCoder, the implementation follows the legacy one and adds theEcalSignalGeneratorPh2class and the newPreMixingEcalPh2Workerworker plugin.A dedicated upgrade ECAL development workflow (*.61299) with the ECAL simulation development on Alpaka (same as *.612 WFs) and premixing stage 1 + stage 2 is added for testing and further development of the premixing code. All configuration changes are activated by the
phase2_ecal_develera andpremix_stage2modifier.The ECAL Phase 2 TP emulation was added to the new premixing workflow and the ECAL development workflows (.61, .612) as well.
No changes are expected for the default Phase 2 simulation and premixing.
PR validation:
Passes the newly created 34634.61299 workflow and the existing 34634.612 workflow.
Backport of #51358 to be used for special productions in the next Phase 2 MC campaign.