Add ECAL Phase 2 digis and TP digis validation by thomreis · Pull Request #51400 · cms-sw/cmssw

thomreis · 2026-07-03T12:06:58Z

PR description:

This PR adds validation histograms for the ECAL Phase 2 digis and TP digis. The validation is activated with the eras phase2_ecal_devel and phase2_ecalTP_devel, respectively.

PR validation:

Tested with the ECAL Phase 2 developments workflows 34434.612, 34634.612, 34634.61299. The newly added histograms appear in the DQM ROOT file and are filled.

cmsbuild · 2026-07-03T12:07:23Z

cms-bot internal usage

thomreis · 2026-07-03T12:07:36Z

type ecal

cmsbuild · 2026-07-03T12:09:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51400/50065

There are other open Pull requests which might conflict with changes you have proposed:
- File Validation/Configuration/python/globalValidation_cff.py modified in PR(s): MC-truth graph prototype #51213

cmsbuild · 2026-07-03T12:09:26Z

A new Pull Request was created by @thomreis for master.

It involves the following packages:

Validation/Configuration (dqm, simulation)
Validation/EcalDigis (dqm)
Validation/EcalTriggerPrimitives (l1)

@BenjaminRS, @civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @kpedro88, @mdhildreth, @quinnanm, @rseidita can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @denizsun, @missirol, @mmusich, @rchatter, @rovere, @salimcerci, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

thomreis · 2026-07-03T12:32:26Z

please test

cmsbuild · 2026-07-03T14:55:06Z

+1

Size: This PR adds an extra 32KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d37982/54493/summary.html
COMMIT: 963781b
CMSSW: CMSSW_20_1_X_2026-07-03-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51400/54493/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3547476
DQMHistoTests: Total failures: 29
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3547429
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1509.69 KiB( 44 files compared)
DQMHistoSizes: changed ( 34434.0,... ): 337.924 KiB EcalDigisV/EcalTriggerPrimitivesTask
DQMHistoSizes: changed ( 34434.0,... ): -35.986 KiB EcalDigisV/EcalDigiTask
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

civanch · 2026-07-04T11:24:53Z

+simulation

gabrielmscampos · 2026-07-06T09:00:52Z

+void EcalDigisValidationPh2::bookHistograms(DQMStore::IBooker& ibooker, edm::Run const&, edm::EventSetup const&) {
+  Char_t histo[200];
+
+  ibooker.setCurrentFolder("EcalDigisV/EcalDigiTask");
+
+  sprintf(histo, "EcalDigiTask Gun Momentum");
+  meGunEnergy_ = ibooker.book1D(histo, histo, 100, 0., 1000.);
+
+  sprintf(histo, "EcalDigiTask Gun Eta");
+  meGunEta_ = ibooker.book1D(histo, histo, 700, -3.5, 3.5);
+
+  sprintf(histo, "EcalDigiTask Gun Phi");
+  meGunPhi_ = ibooker.book1D(histo, histo, 360, 0., 360.);
+
+  sprintf(histo, "EcalDigiTask maximum Digi over Sim ratio");
+  meDigiSimRatio_ = ibooker.book1D(histo, histo, 100, 0., 2.);
+
+  sprintf(histo, "EcalDigiTask maximum Digi over Sim ratio gt 10 ADC");
+  meDigiSimRatiogt10ADC_ = ibooker.book1D(histo, histo, 100, 0., 2.);
+
+  sprintf(histo, "EcalDigiTask maximum Digi over Sim ratio gt 100 ADC");
+  meDigiSimRatiogt100ADC_ = ibooker.book1D(histo, histo, 100, 0., 2.);
+
+  sprintf(histo, "EcalDigiTask occupancy");
+  meDigiOccupancy_ = ibooker.book2D(histo, histo, 360, 0., 360., 170, -85., 85.);
+
+  sprintf(histo, "EcalDigiTask digis multiplicity");
+  meDigiMultiplicity_ = ibooker.book1D(histo, histo, 612, 0., 61200);
+
+  sprintf(histo, "EcalDigiTask global pulse shape");
+  meDigiADCGlobal_ = ibooker.bookProfile(histo, histo, kMaxSamples_, 0, kMaxSamples_, 10000, 0., 1000.);
+
+  for (int i = 0; i < kMaxSamples_; ++i) {
+    sprintf(histo, "EcalDigiTask analog pulse %02d", i + 1);
+    meDigiADCAnalog_[i] = ibooker.book1D(histo, histo, 4000, 0., 400.);
+
+    sprintf(histo, "EcalDigiTask ADC pulse %02d Gain 10", i + 1);
+    meDigiADCg10_[i] = ibooker.book1D(histo, histo, 4096, -0.5, 4095.5);
+
+    sprintf(histo, "EcalDigiTask ADC pulse %02d Gain 1", i + 1);
+    meDigiADCg1_[i] = ibooker.book1D(histo, histo, 4096, -0.5, 4095.5);
+
+    sprintf(histo, "EcalDigiTask gain pulse %02d", i + 1);
+    meDigiGain_[i] = ibooker.book1D(histo, histo, 2, 0, 2);
+  }
+
+  sprintf(histo, "EcalDigiTask pedestal for pre-sample");
+  mePedestal_ = ibooker.book1D(histo, histo, 4096, -0.5, 4095.5);
+
+  sprintf(histo, "EcalDigiTask maximum position gt 10 ADC");
+  meMaximumgt10ADC_ = ibooker.book1D(histo, histo, kMaxSamples_, 0., static_cast<double>(kMaxSamples_));
+
+  sprintf(histo, "EcalDigiTask maximum position gt 100 ADC");
+  meMaximumgt100ADC_ = ibooker.book1D(histo, histo, kMaxSamples_, 0., static_cast<double>(kMaxSamples_));
+
+  sprintf(histo, "EcalDigiTask ADC counts after gain switch");
+  menADCafterSwitch_ = ibooker.book1D(histo, histo, kMaxSamples_, 0., static_cast<double>(kMaxSamples_));
+}


Please, use std::string instead of a fixed sized buffer + sprintf. For the loop you can use std::format to concatenate an std::string with the counter.

gabrielmscampos · 2026-07-06T09:11:56Z

+          meDigiADCGlobal_->Fill(sample, ebAnalogSignal[sample]);
+      }
+
+      if (ebSimMap[ebid.rawId()] != 0.) {


std::map::operator[] will silently create a key:value (with value 0.0f) pair in ebSimMap if ebid.rawId() is not found in the map. The initial filling of ebSimMap comes from looping over barrelHits (line 214), and here ebid.rawId() comes from looping over digis. You may consider the use of std::map:find(), to avoid filling ebSimMap silently.

gabrielmscampos · 2026-07-06T09:13:33Z

+#include <map>
+
+class EcalDigisValidationPh2 : public DQMEDAnalyzer {
+  typedef std::map<uint32_t, float, std::less<uint32_t> > MapType;


std::less<uint32_t> is already the default comparison object, you can remove it.

gabrielmscampos · 2026-07-06T10:03:30Z

+void EcalTPsValidationPh2::bookHistograms(DQMStore::IBooker& ibooker, edm::Run const&, edm::EventSetup const&) {
+  Char_t histo[200];
+
+  ibooker.setCurrentFolder("EcalDigisV/EcalTriggerPrimitivesTask");
+
+  sprintf(histo, "EcalTPDigiTask TP digis multiplicity");
+  meTPDigisMultiplicity_ = ibooker.book1D(histo, histo, 613, 0, 61300);
+
+  sprintf(histo, "EcalTPDigiTask TP digi occupancy");
+  meTPDigiOccupancy_ = ibooker.book2D(histo, histo, 360, 0., 360., 170, -85., 85.);
+
+  sprintf(histo, "EcalTPDigiTask TP digi size");
+  meTPDigiSize_ = ibooker.book1D(histo, histo, kMaxSamples_, 0, kMaxSamples_);
+
+  sprintf(histo, "EcalTPDigiTask TP digi encoded ET");
+  meTPDigiEt_ = ibooker.book1D(histo, histo, 1025, -1, 1024);
+
+  sprintf(histo, "EcalTPDigiTask TP digi spike flag");
+  meTPDigiSpike_ = ibooker.book1D(histo, histo, 2, 0, 2);
+
+  sprintf(histo, "EcalTPDigiTask TP digi time");
+  meTPDigiTime_ = ibooker.book1D(histo, histo, 33, -1, 32);
+
+  sprintf(histo, "EcalTPDigiTask TP digi debug flag");
+  meTPDigiDebugFlag_ = ibooker.book1D(histo, histo, 2, 0, 2);
+
+  sprintf(histo, "EcalTPDigiTask TP digi sample of interest");
+  meTPDigiSOI_ = ibooker.book1D(histo, histo, kMaxSamples_ + 1, -1, kMaxSamples_);
+
+  for (unsigned int i = 0; i < kMaxSamples_; ++i) {
+    sprintf(histo, "EcalTPDigiTask TP sample %02d encoded ET", i);
+    meTPSampleEt_[i] = ibooker.book1D(histo, histo, 1024, 0, 1024);
+
+    sprintf(histo, "EcalTPDigiTask TP sample %02d spike flag", i);
+    meTPSampleSpike_[i] = ibooker.book1D(histo, histo, 2, 0, 2);
+
+    sprintf(histo, "EcalTPDigiTask TP sample %02d time", i);
+    meTPSampleTime_[i] = ibooker.book1D(histo, histo, 32, 0, 32);
+  }
+}


same here for std::string, forgot to comment before (sorry!)

thomreis · 2026-07-08T07:39:21Z

please test

cmsbuild · 2026-07-08T07:40:43Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51400/50118

There are other open Pull requests which might conflict with changes you have proposed:
- File Validation/Configuration/python/globalValidation_cff.py modified in PR(s): MC-truth graph prototype #51213

cmsbuild · 2026-07-08T07:41:07Z

Pull request #51400 was updated. @BenjaminRS, @ctarricone, @gabrielmscampos, @quinnanm, @rseidita can you please check and sign again.

cmsbuild · 2026-07-08T09:25:41Z

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d37982/54589/summary.html
COMMIT: 4d1a752
CMSSW: CMSSW_20_1_X_2026-07-07-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51400/54589/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3547476
DQMHistoTests: Total failures: 107
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3547351
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1509.69 KiB( 44 files compared)
DQMHistoSizes: changed ( 34434.0,... ): 337.924 KiB EcalDigisV/EcalTriggerPrimitivesTask
DQMHistoSizes: changed ( 34434.0,... ): -35.986 KiB EcalDigisV/EcalDigiTask
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

thomreis · 2026-07-08T10:31:02Z

Hi @gabrielmscampos can you please sign this again?

gabrielmscampos · 2026-07-08T12:46:11Z

+dqm

quinnanm · 2026-07-08T18:26:13Z

+l1

cmsbuild · 2026-07-08T18:26:35Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @sextonkennedy, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-07-08T20:28:25Z

+1

Add ECAL Phase 2 digis and TP digis validation.

963781b

cmsbuild added this to the CMSSW_20_1_X milestone Jul 3, 2026

cmsbuild added simulation-pending dqm-pending l1-pending pending-signatures tests-pending orp-pending code-checks-pending labels Jul 3, 2026

cmsbuild added the ecal label Jul 3, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 3, 2026

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2026

thomreis mentioned this pull request Jul 3, 2026

Add ECAL Phase 2 digis and TP digis validation - 200X #51403

Merged

cmsbuild added tests-approved and removed tests-started labels Jul 3, 2026

cmsbuild added simulation-approved and removed simulation-pending labels Jul 4, 2026

gabrielmscampos reviewed Jul 6, 2026

View reviewed changes

Implement review comments.

fdba574

cmsbuild removed the tests-approved label Jul 6, 2026

cmsbuild added dqm-pending tests-pending code-checks-pending labels Jul 8, 2026

cmsbuild added tests-started and removed tests-pending labels Jul 8, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jul 8, 2026

cmsbuild added tests-approved and removed tests-started labels Jul 8, 2026

cmsbuild mentioned this pull request Jul 8, 2026

MC-truth graph prototype #51213

Merged

cmsbuild added dqm-approved and removed dqm-pending labels Jul 8, 2026

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Jul 8, 2026

cmsbuild added orp-approved and removed orp-pending labels Jul 8, 2026

cmsbuild merged commit 7eb34e4 into cms-sw:master Jul 8, 2026
18 checks passed

cmsbuild mentioned this pull request Jul 9, 2026

Track Purity DNN for Phase-2 HLT #51084

Merged

thomreis deleted the ecal-phase2-digi-tp-val branch July 9, 2026 12:15

Uh oh!

Conversation

thomreis commented Jul 3, 2026

PR description:

PR validation:

Uh oh!

cmsbuild commented Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thomreis commented Jul 3, 2026

Uh oh!

cmsbuild commented Jul 3, 2026

Uh oh!

cmsbuild commented Jul 3, 2026

Uh oh!

thomreis commented Jul 3, 2026

Uh oh!

cmsbuild commented Jul 3, 2026

Comparison Summary

Uh oh!

civanch commented Jul 4, 2026

Uh oh!

gabrielmscampos Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

gabrielmscampos Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

gabrielmscampos Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

gabrielmscampos Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thomreis commented Jul 8, 2026

Uh oh!

cmsbuild commented Jul 8, 2026

Uh oh!

cmsbuild commented Jul 8, 2026

Uh oh!

cmsbuild commented Jul 8, 2026

Comparison Summary

Uh oh!

thomreis commented Jul 8, 2026

Uh oh!

gabrielmscampos commented Jul 8, 2026

Uh oh!

quinnanm commented Jul 8, 2026

Uh oh!

cmsbuild commented Jul 8, 2026

Uh oh!

mandrenguyen commented Jul 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmsbuild commented Jul 3, 2026 •

edited

Loading

gabrielmscampos Jul 6, 2026 •

edited

Loading