Skip to content

Add ECAL Phase 2 digis and TP digis validation - 200X - #51403

Merged
cmsbuild merged 4 commits into
cms-sw:CMSSW_20_0_Xfrom
thomreis:ecal-phase2-digi-tp-val
Jul 9, 2026
Merged

cmsbuild merged 4 commits into
cms-sw:CMSSW_20_0_Xfrom
thomreis:ecal-phase2-digi-tp-val

Conversation

@thomreis

@thomreis thomreis commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

PR description:

This PR adds validation histograms for the ECAL Phase 2 digis and TP digis. The validation is activated with the eras phase2_ecal_devel and phase2_ecalTP_devel, respectively.

PR validation:

Tested with the ECAL Phase 2 developments workflows 34434.612, 34634.612, 34634.61299. The newly added histograms appear in the DQM ROOT file and are filled.

Backport of #51400 to be used for special productions in the next Phase 2 MC campaign.

@cmsbuild

cmsbuild commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @thomreis for CMSSW_20_0_X.

It involves the following packages:

  • Validation/Configuration (dqm, simulation)
  • Validation/EcalDigis (dqm)
  • Validation/EcalTriggerPrimitives (l1)

@BenjaminRS, @civanch, @cmsbuild, @ctarricone, @gabrielmscampos, @kpedro88, @mdhildreth, @quinnanm, @rseidita can you please review it and eventually sign? Thanks.
@ReyerBand, @apsallid, @argiro, @denizsun, @missirol, @mmusich, @rchatter, @rovere, @salimcerci, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@thomreis

thomreis commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

type ecal

@thomreis

thomreis commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

backport of #51400

@thomreis

thomreis commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a8dc7/54496/summary.html
COMMIT: 963781b
CMSSW: CMSSW_20_0_X_2026-07-03-1100/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51403/54496/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3248098
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248080
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1207.752 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 34434.0,... ): 337.924 KiB EcalDigisV/EcalTriggerPrimitivesTask
  • DQMHistoSizes: changed ( 34434.0,... ): -35.986 KiB EcalDigisV/EcalDigiTask
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@civanch

civanch commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

+simulation

however, I am not sure if the backport is needed.

@thomreis

thomreis commented Jul 5, 2026

Copy link
Copy Markdown
Contributor Author

+simulation

however, I am not sure if the backport is needed.

Since we would like to have some samples produced centrally with the ECAL development workflows, having the digis validation as part of it would be very useful to verify the production.

@cmsbuild

cmsbuild commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Pull request #51403 was updated. @BenjaminRS, @cmsbuild, @ctarricone, @gabrielmscampos, @quinnanm, @rseidita can you please check and sign again.

@thomreis

thomreis commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Pull request #51403 was updated. @BenjaminRS, @cmsbuild, @ctarricone, @gabrielmscampos, @quinnanm, @rseidita can you please check and sign again.

@thomreis

thomreis commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

please test

@cmsbuild

cmsbuild commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3a8dc7/54590/summary.html
COMMIT: 4d1a752
CMSSW: CMSSW_20_0_X_2026-07-07-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51403/54590/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3248098
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3248068
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1207.752 KiB( 43 files compared)
  • DQMHistoSizes: changed ( 34434.0,... ): 337.924 KiB EcalDigisV/EcalTriggerPrimitivesTask
  • DQMHistoSizes: changed ( 34434.0,... ): -35.986 KiB EcalDigisV/EcalDigiTask
  • Checked 191 log files, 159 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

@thomreis

thomreis commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

Hi @gabrielmscampos can you please sign this PR again?

@gabrielmscampos

Copy link
Copy Markdown
Member

+dqm

@quinnanm

quinnanm commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

+l1

@cmsbuild

cmsbuild commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_20_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 7fd932b into cms-sw:CMSSW_20_0_X Jul 9, 2026
18 checks passed
@thomreis
thomreis deleted the ecal-phase2-digi-tp-val branch July 9, 2026 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants