Add premixing to development ECAL Phase 2 simulation by thomreis · Pull Request #51358 · cms-sw/cmssw

thomreis · 2026-06-29T10:10:10Z

PR description:

This adds the premixing capability to the ECAL Phase 2 simulation. In addition to the already existing premixing case in the EcalLiteDTUCoder , the implementation follows the legacy one and adds the EcalSignalGeneratorPh2 class and the new PreMixingEcalPh2Worker worker plugin.

A dedicated upgrade ECAL development workflow (*.61299) with the ECAL simulation development on Alpaka (same as *.612 WFs) and premixing stage 1 + stage 2 is added for testing and further development of the premixing code. All configuration changes are activated by the phase2_ecal_devel era and premix_stage2 modifier.

The ECAL Phase 2 TP emulation was added to the new premixing workflow and the ECAL development workflows (.61, .612) as well.

No changes are expected for the default Phase 2 simulation and premixing.

PR validation:

Passes the newly created 34634.61299 workflow and the existing 34634.612 workflow.

thomreis · 2026-06-29T10:10:23Z

type ecal

cmsbuild · 2026-06-29T10:10:34Z

cms-bot internal usage

cmsbuild · 2026-06-29T10:12:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51358/49997

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): Add HGCAL/TICL NanoAOD for offline #51242
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Rpc digi dev v9 #47447, Displaced Particle Gun #51006, mkfit for LST-seeded in offline phase-2 #51140, MC-truth graph prototype #51213, Add HGCAL/TICL NanoAOD for offline #51242, Adding recHit masking to extended pixel tracks in heterogeneous CA #51268, Add additional processes to ECAL development matrix workflows. #51269
- File SimCalorimetry/Configuration/python/SimCalorimetry_EventContent_cff.py modified in PR(s): Particle Flow cluster validation in ECAL #50292

cmsbuild · 2026-06-29T10:13:09Z

A new Pull Request was created by @thomreis for master.

It involves the following packages:

Configuration/PyReleaseValidation (pdmv)
RecoLocalCalo/EcalRecProducers (reconstruction)
SimCalorimetry/Configuration (simulation)
SimCalorimetry/EcalSimAlgos (simulation)
SimCalorimetry/EcalSimProducers (simulation)
SimGeneral/PreMixingModule (simulation)

@AdrianoDee, @DickyChant, @Moanwar, @antoniovagnerini, @civanch, @cmsbuild, @jfernan2, @kfjack, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @srimanob, @sroychow can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @apsallid, @argiro, @denizsun, @fabiocos, @makortel, @martinamalberti, @rchatter, @rovere, @salimcerci, @sameasy, @slomeo, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

thomreis · 2026-06-29T10:25:27Z

please test

cmsbuild · 2026-06-29T15:04:46Z

+1

Size: This PR adds an extra 68KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85709c/54364/summary.html
COMMIT: 187d7bc
CMSSW: CMSSW_20_1_X_2026-06-29-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51358/54364/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3414477
DQMHistoTests: Total failures: 38
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3414421
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

kpedro88 · 2026-06-29T17:19:22Z

@thomreis thanks for this development! I have no particular comments on the code. Do you have higher-statistics validation plots that show sufficient agreement between classical and premixing for the Phase 2 ECAL?

thomreis · 2026-06-30T07:07:08Z

@thomreis thanks for this development! I have no particular comments on the code. Do you have higher-statistics validation plots that show sufficient agreement between classical and premixing for the Phase 2 ECAL?

Not yet. This PR is the technical part to get premixing work in principle. With it and when PR #51269 gets merged we want to produce some larger samples to do studies.

cmsbuild · 2026-06-30T09:34:54Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51358/50021

There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/PyReleaseValidation/README.md modified in PR(s): Add HGCAL/TICL NanoAOD for offline #51242
- File Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py modified in PR(s): Rpc digi dev v9 #47447, Displaced Particle Gun #51006, MC-truth graph prototype #51213, Add HGCAL/TICL NanoAOD for offline #51242, Adding recHit masking to extended pixel tracks in heterogeneous CA #51268, Add additional processes to ECAL development matrix workflows. #51269
- File SimCalorimetry/Configuration/python/SimCalorimetry_EventContent_cff.py modified in PR(s): Particle Flow cluster validation in ECAL #50292

thomreis · 2026-07-07T17:14:37Z

please test

cmsbuild · 2026-07-07T19:27:51Z

+1

Size: This PR adds an extra 52KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85709c/54573/summary.html
COMMIT: 1e75350
CMSSW: CMSSW_20_1_X_2026-07-07-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51358/54573/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3547841
DQMHistoTests: Total failures: 37
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3547786
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

quinnanm · 2026-07-08T01:30:06Z

+l1

mandrenguyen · 2026-07-08T05:42:55Z

@cms-sw/simulation-l2 @cms-sw/pdmv-l2 please have a look

mandrenguyen · 2026-07-08T05:42:58Z

urgent

civanch · 2026-07-08T09:57:21Z

+1

AdrianoDee · 2026-07-09T22:16:44Z

test parameters:

relval_opts = -w upgrade
relvals = 34634.61299, 34634.612, 34634.6199

AdrianoDee · 2026-07-09T22:16:55Z

please test

cmsbuild · 2026-07-10T00:49:44Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85709c/54656/summary.html
COMMIT: 1e75350
CMSSW: CMSSW_20_1_X_2026-07-09-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51358/54656/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3548186
DQMHistoTests: Total failures: 57
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3548111
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

AdrianoDee · 2026-07-10T08:31:20Z

+pdmv

cmsbuild · 2026-07-10T08:31:46Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-07-10T10:02:21Z

+1

cmsbuild added this to the CMSSW_20_1_X milestone Jun 29, 2026

cmsbuild added reconstruction-pending simulation-pending pending-signatures tests-pending orp-pending pdmv-pending code-checks-pending ecal labels Jun 29, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 29, 2026

cmsbuild added tests-started and removed tests-pending labels Jun 29, 2026

cmsbuild added tests-approved and removed tests-started labels Jun 29, 2026

cmsbuild added l1-pending tests-pending code-checks-pending and removed tests-approved code-checks-approved labels Jun 30, 2026

cmsbuild removed the code-checks-pending label Jun 30, 2026

thomreis mentioned this pull request Jul 7, 2026

Add premixing to development ECAL Phase 2 simulation - 200X #51436

Merged

cmsbuild added tests-started and removed tests-pending labels Jul 7, 2026

cmsbuild added tests-approved and removed tests-started labels Jul 7, 2026

cmsbuild added l1-approved and removed l1-pending labels Jul 8, 2026

cmsbuild added the urgent label Jul 8, 2026

cmsbuild added simulation-approved and removed simulation-pending labels Jul 8, 2026

cmsbuild mentioned this pull request Jul 8, 2026

MC-truth graph prototype #51213

Merged

cmsbuild added tests-started and removed tests-approved labels Jul 9, 2026

cmsbuild added tests-approved and removed tests-started labels Jul 10, 2026

cmsbuild removed pending-signatures pdmv-pending labels Jul 10, 2026

cmsbuild mentioned this pull request Jul 10, 2026

Vecgeom: Update to version v2.1.0 cms-sw/cmsdist#10711

Merged

Uh oh!

Conversation

thomreis commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR description:

PR validation:

Uh oh!

thomreis commented Jun 29, 2026

Uh oh!

cmsbuild commented Jun 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Jun 29, 2026

Uh oh!

cmsbuild commented Jun 29, 2026

Uh oh!

thomreis commented Jun 29, 2026

Uh oh!

cmsbuild commented Jun 29, 2026

Comparison Summary

Uh oh!

kpedro88 commented Jun 29, 2026

Uh oh!

thomreis commented Jun 30, 2026

Uh oh!

cmsbuild commented Jun 30, 2026

Uh oh!

thomreis commented Jul 7, 2026

Uh oh!

cmsbuild commented Jul 7, 2026

Comparison Summary

Uh oh!

quinnanm commented Jul 8, 2026

Uh oh!

mandrenguyen commented Jul 8, 2026

Uh oh!

mandrenguyen commented Jul 8, 2026

Uh oh!

civanch commented Jul 8, 2026

Uh oh!

AdrianoDee commented Jul 9, 2026

Uh oh!

AdrianoDee commented Jul 9, 2026

Uh oh!

cmsbuild commented Jul 10, 2026

Comparison Summary

Uh oh!

AdrianoDee commented Jul 10, 2026

Uh oh!

cmsbuild commented Jul 10, 2026

Uh oh!

mandrenguyen commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

thomreis commented Jun 29, 2026 •

edited

Loading

cmsbuild commented Jun 29, 2026 •

edited

Loading