Skip to content

Provide configuration descriptions to MTD local reconstruction modules - #51273

Merged
cmsbuild merged 2 commits into
cms-sw:masterfrom
mmusich:mm_mtd_validateConfiguration
Jun 23, 2026
Merged

Provide configuration descriptions to MTD local reconstruction modules#51273
cmsbuild merged 2 commits into
cms-sw:masterfrom
mmusich:mm_mtd_validateConfiguration

Conversation

@mmusich

@mmusich mmusich commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

PR description:

The goal of this PR is to update MTDUncalibratedRecHitProducer and MTDRecHitProducer in order to make them fully suitable for the HLT usage, by adding a fillDescriptions method.
As these module make use of plugin factories, additional changes following the line of these instructions were added.
The missing configuration validation was spotted thanks to this script run on CMSSW_20_1_X_2026-06-21-0000.

PR validation:

I've run successfully:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.

@mmusich

mmusich commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

test parameters:

  • workflows = ph2_hlt

@cmsbuild cmsbuild added this to the CMSSW_20_1_X milestone Jun 21, 2026
@mmusich

mmusich commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

type ngt

@cmsbuild

cmsbuild commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@mmusich

mmusich commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • RecoLocalFastTime/FTLCommonAlgos (reconstruction)
  • RecoLocalFastTime/FTLRecProducers (reconstruction)

@Moanwar, @jfernan2, @mandrenguyen, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos, @martinamalberti this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 28KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e44ad9/54161/summary.html
COMMIT: 159f9d9
CMSSW: CMSSW_20_1_X_2026-06-21-0000/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51273/54161/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 3872067
  • DQMHistoTests: Total failures: 68
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3871981
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 58 files compared)
  • Checked 249 log files, 203 edm output root files, 59 DQM output files

@jfernan2

Copy link
Copy Markdown
Contributor

+1
Thanks @mmusich

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 3d6dddc into cms-sw:master Jun 23, 2026
11 checks passed
@mmusich
mmusich deleted the mm_mtd_validateConfiguration branch June 23, 2026 07:37
mmusich pushed a commit to mmusich/cmssw that referenced this pull request Jun 23, 2026
…tion

Provide configuration descriptions to MTD local reconstruction modules
NJManganelli pushed a commit to NJManganelli/cmssw that referenced this pull request Jul 25, 2026
…tion

Provide configuration descriptions to MTD local reconstruction modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants