Skip to content

[20.0.X] Implement MIP Timing Detector reconstruction sequence for Phase-2 HLT - #51568

Merged
cmsbuild merged 11 commits into
cms-sw:CMSSW_20_0_Xfrom
mmusich:mm_mtd_at_HLT_20_0_X
Jul 31, 2026
Merged

[20.0.X] Implement MIP Timing Detector reconstruction sequence for Phase-2 HLT #51568
cmsbuild merged 11 commits into
cms-sw:CMSSW_20_0_Xfrom
mmusich:mm_mtd_at_HLT_20_0_X

Conversation

@mmusich

@mmusich mmusich commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

backport of #51170
backport of #51237
backport of #51273

PR description:

Combined backport of #51170, #51237 and #51273 for possible usage in the release in which the phase-2 Summer 26 MC production will happen.

PR validation:

See corresponding master PRs.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild

Copy link
Copy Markdown
Contributor

Pull request #51568 was updated.

@cmsbuild

cmsbuild commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@mmusich

mmusich commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

test parameters:

  • enable = hlt_p2_integration
  • workflows = ph2_hlt

@mmusich

mmusich commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 92KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d037b7/54946/summary.html
COMMIT: 133df09
CMSSW: CMSSW_20_0_X_2026-07-27-1100/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51568/54946/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 58
  • DQMHistoTests: Total histograms compared: 3791226
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3791200
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 57 files compared)
  • Checked 246 log files, 201 edm output root files, 58 DQM output files
  • TriggerResults: no differences found

@mmusich

mmusich commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

+hlt

@cmsbuild

cmsbuild commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for CMSSW_20_0_X.

It involves the following packages:

  • Configuration/EventContent (operations)
  • Configuration/ProcessModifiers (operations)
  • Configuration/PyReleaseValidation (pdmv)
  • HLTrigger/Configuration (hlt)
  • HLTriggerOffline/Common (dqm)
  • RecoLocalFastTime/Configuration (reconstruction)
  • RecoLocalFastTime/FTLCommonAlgos (reconstruction)
  • RecoLocalFastTime/FTLRecProducers (reconstruction)
  • RecoMTD/Configuration (reconstruction)
  • SimFastTiming/MtdAssociatorProducers (simulation)
  • Validation/MtdValidation (dqm)

@AdrianoDee, @DickyChant, @Moanwar, @antoniovagnerini, @civanch, @ctarricone, @gabrielmscampos, @jfernan2, @kfjack, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @rseidita, @srimanob, @sroychow can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ReyerBand, @SohamBhattacharya, @VourMa, @argiro, @fabiocos, @makortel, @martinamalberti, @missirol, @mtosi, @rchatter, @rovere, @slomeo, @thomreis, @wang0jin this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Moanwar

Moanwar commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

+1

@gabrielmscampos

Copy link
Copy Markdown
Member

+hlt

@mmusich

mmusich commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

+hlt

I guess you meant +dqm @gabrielmscampos :)

@gabrielmscampos

Copy link
Copy Markdown
Member

+hlt

I guess you meant +dqm @gabrielmscampos :)

haha yes, sorry.

@gabrielmscampos

Copy link
Copy Markdown
Member

+dqm

@mmusich

mmusich commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

@cms-sw/simulation-l2 @cms-sw/pdmv-l2 it would be nice to have this in 20_0_X, if you can take a look / sign.

@kpedro88

Copy link
Copy Markdown
Contributor

+1
for code improvements in SimFastTiming/MtdAssociatorProducers/plugins/MtdRecoClusterToSimLayerClusterAssociatorEDProducer.cc

@antoniovagnerini

Copy link
Copy Markdown

+pdmv

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_20_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_20_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

Since we didn't discuss this at the ORP can you explain what the impact is? Presumably I could figure it out by looking at the 3 master PRs, it would be convenient to summarize here. Is this reconstruction sequence not a part of standard workflows?

@mmusich

mmusich commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Hi @mandrenguyen

Since we didn't discuss this at the ORP can you explain what the impact is? Presumably I could figure it out by looking at the 3 master PRs, it would be convenient to summarize here. Is this reconstruction sequence not a part of standard workflows?

yes, the MTD reconstruction is not part of the standard HLT sequences. This PR allows to run it (on demand) via process modifier in the release in which the sample for the L1+TSG production will happen. There are zero regressions expected.

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 45d3613 into cms-sw:CMSSW_20_0_X Jul 31, 2026
10 checks passed
@mmusich
mmusich deleted the mm_mtd_at_HLT_20_0_X branch July 31, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants