Skip to content

Follow-up to MTD reconstruction at HLT - #51237

Merged
cmsbuild merged 2 commits into
cms-sw:masterfrom
mmusich:mm_mtd_at_hlt_reprise
Jun 23, 2026
Merged

Follow-up to MTD reconstruction at HLT#51237
cmsbuild merged 2 commits into
cms-sw:masterfrom
mmusich:mm_mtd_at_hlt_reprise

Conversation

@mmusich

@mmusich mmusich commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

PR description:

This PR is a follow-up to #51170.
When the mtd_at_hlt modifier is active:

  • save in the FEVTDEBUGHLTEventContent the MTD local and "global" reco products as well as the 4D vertices
  • complete the HLT MTD Validation, by enabling both MtdTracksValidation and the corresponding harvesting module (after having protected the whole chain against missing products).

PR validation:

Run successfully runTheMatrix.py -l 34434.7522 -t 4 -j 8 and checked that the event products of the step2 file are as expected.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild cmsbuild added this to the CMSSW_20_1_X milestone Jun 17, 2026
@mmusich

mmusich commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

test parameters:

  • workflows = ph2_hlt

@cmsbuild

cmsbuild commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@mmusich

mmusich commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51237/49807

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • Configuration/EventContent (operations)
  • RecoLocalFastTime/Configuration (reconstruction)
  • RecoMTD/Configuration (reconstruction)
  • SimFastTiming/MtdAssociatorProducers (simulation)
  • Validation/MtdValidation (dqm)

@Moanwar, @civanch, @cmsbuild, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @rseidita, @srimanob can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @martinamalberti this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich

mmusich commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ceb4de/54040/summary.html
COMMIT: 6ea1e16
CMSSW: CMSSW_20_1_X_2026-06-17-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/51237/54040/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 3872067
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3872044
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 70.775 KiB( 58 files compared)
  • DQMHistoSizes: changed ( 34434.7522 ): 70.775 KiB HLT/MTD
  • Checked 249 log files, 203 edm output root files, 59 DQM output files

@civanch

civanch commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

+simulation

@jfernan2

Copy link
Copy Markdown
Contributor

+1

@mmusich

mmusich commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

@cms-sw/dqm-l2 kind ping

@rseidita

Copy link
Copy Markdown
Contributor

+dqm

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit cd9d0c7 into cms-sw:master Jun 23, 2026
11 checks passed
@mmusich
mmusich deleted the mm_mtd_at_hlt_reprise branch June 23, 2026 07:37
NJManganelli pushed a commit to NJManganelli/cmssw that referenced this pull request Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants