-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Remove Run 3 PU GPU workflows #51159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+0
−26
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't these be removed as well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the Run 3 noPU workflows for now because they technically run and the exact route to dismantle Run 1-3 reconstruction (and simulation) capability in 20_1_X has not been agreed yet. I'm happy to remove them though if that is deemed appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cms-sw/pdmv-l2 Any thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a similar doubt, not specifically related to these GPU wfs. In my personal opinion, we should start removing the Run1-3 wfs in general. Unless we want to keep Run1-3 capabilities still alive in 20_1_X for some reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time of the release planning XC a month ago (https://indico.cern.ch/event/1678193/) 4 use cases for running (parts of) Run 3 data/simulation in 20_1_X (and possibly beyond)
/EGamma*/Run2025G-v1/RAWdata for ECAL+EGamma phase 2 developments (Tests for processing/EGamma*/Run2025G-v1/RAWin CMSSW_20 #50773)To my knowledge the fate of these use cases has not been decided. There was some discussion on the PF use case in https://indico.cern.ch/event/1681572/, but I'm not aware of further discussion on the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to move the general discussion on how long the Run 1-3 processing capability is needed to #51191 and the per use case issues linked therein.
In the meantime I think it would be nice to avoid reporting the failures of these workflows in the IBs.