Remove Run 3 PU GPU workflows - #51159
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51159/49686 |
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @kfjack, @miquork, @sroychow can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable gpu |
|
@cmsbuild, please test |
|
FYI @cms-sw/heterogeneous-l2 |
| @@ -30,15 +27,6 @@ | |||
| # Alpaka pixel-only quadruplets: ZMM: any backend, any backend vs cpu validation, profiling | |||
| # Alpaka pixel-only triplets: ZMM: any backend, any backend vs cpu validation, profiling | |||
| # Alpaka pixel-only quadruplets: Single Nu E10: any backend | |||
There was a problem hiding this comment.
shouldn't these be removed as well ?
There was a problem hiding this comment.
I kept the Run 3 noPU workflows for now because they technically run and the exact route to dismantle Run 1-3 reconstruction (and simulation) capability in 20_1_X has not been agreed yet. I'm happy to remove them though if that is deemed appropriate.
There was a problem hiding this comment.
@cms-sw/pdmv-l2 Any thoughts?
There was a problem hiding this comment.
I had a similar doubt, not specifically related to these GPU wfs. In my personal opinion, we should start removing the Run1-3 wfs in general. Unless we want to keep Run1-3 capabilities still alive in 20_1_X for some reason.
There was a problem hiding this comment.
At the time of the release planning XC a month ago (https://indico.cern.ch/event/1678193/) 4 use cases for running (parts of) Run 3 data/simulation in 20_1_X (and possibly beyond)
- High-pileup
/EGamma*/Run2025G-v1/RAWdata for ECAL+EGamma phase 2 developments (Tests for processing/EGamma*/Run2025G-v1/RAWin CMSSW_20 #50773) - Workflow for (HLT, offline) algorithm benchmarking
- Validation of big changes in MC truth infrastructure
- PF reconstruction on Run 3 high PU data (Enabling PF reconstruction in Phase-2 CMSSW on Run-3 highPU RAW data #50885)
To my knowledge the fate of these use cases has not been decided. There was some discussion on the PF use case in https://indico.cern.ch/event/1681572/, but I'm not aware of further discussion on the others.
There was a problem hiding this comment.
I suggest to move the general discussion on how long the Run 1-3 processing capability is needed to #51191 and the per use case issues linked therein.
In the meantime I think it would be nice to avoid reporting the failures of these workflows in the IBs.
|
-1 Failed Tests: RelVals-AMD_W7900 Failed RelVals-AMD_W7900
Comparison SummarySummary:
AMD_MI300X Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
Max Memory Comparisons exceeding threshold NVIDIA_L40S@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
Max Memory Comparisons exceeding threshold NVIDIA_T4@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
The failure of 34434.404 on AMD GPU seems to be related to #49570 |
|
ignore tests-rejected with ib-failure |
|
Just to clarify, is the preference to get #51199 merged first, and then rebase this PR on top of that leaving the Run 4 workflows untouched? (and likewise for backports to 20_0_X) |
As you prefer. In principle, you could just remove the Run3 ones and leave the Run4 ones untouched here. Then whichever (among this and #51159) enters first, it shouldn't change much, right? |
Good point. Ok, let's do that. |
|
Now only Run 3 PU GPU workflows are removed. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51159/49754 |
|
Pull request #51159 was updated. @AdrianoDee, @DickyChant, @antoniovagnerini, @cmsbuild, @kfjack, @miquork, @sroychow can you please check and sign again. |
|
@cmsbuild, please test |
|
@smuzaffar looks like the workflow completed, but the bot didn't notice? |
|
bot is still waiting for https://cmssdt.cern.ch/jenkins/job/ib-run-pr-unittests/4000/ (unit tests for amd w7900) which failed due to i am retrying that job now |
|
+1 Size: This PR adds an extra 24KB to repository Comparison SummarySummary:
AMD_MI300X Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
AMD_W7900 Comparison SummarySummary:
NVIDIA_H100 Comparison SummarySummary:
NVIDIA_L40S Comparison SummarySummary:
NVIDIA_T4 Comparison SummarySummary:
Max Memory Comparisons exceeding threshold NVIDIA_T4@cms-sw/core-l2 , I found 1 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
|
@cms-sw/pdmv-l2 Kind ping |
|
+pdmv |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
Thanks. 20_0_X backport is in #51243 |
|
+1 |
Remove Run 3 PU GPU workflows
PR description:
These read non-RAW input files and are unlikely to be revived in 20_1_X, so they are removed.
I had missed these in #50954.
Resolves cms-sw/framework-team#2278
PR validation:
I checked
runTheMatrix.py -w gpu -nwithout and with this PR. The 32 workflows failing in the 20_[01]_X GPU tests because ofDictionaryNotFoundare removed from the list of workflows. After limiting the PR to only the removal of Run 3 workflows, 24 workflows are removed.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
To be backported to 20_0_X.