Add optimization flags to ucx.spec while keeping ucx portable - #10658
Add optimization flags to ucx.spec while keeping ucx portable#10658ghyls wants to merge 1 commit into
ucx.spec while keeping ucx portable#10658Conversation
|
cms-bot internal usage |
|
Pull request #10658 was updated. |
| --with-pic \ | ||
| --with-gnu-ld \ | ||
| %ifarch x86_64 | ||
| --with-march=x86-64-v2 \ |
There was a problem hiding this comment.
@ghyls , by default now we build for x86-64-v3. Should we enable multi-vectorization of ucx too i.e. just like few other externals (https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_20_1_X/master/cmssw-vectorization.file) we build ucx also for x86-64-v3 and x86-64-v2 (where by default x86-64-v3 libs are used)
There was a problem hiding this comment.
Naively I think we should build one version for x86-64-v2 (ssse4.2) and one for x86-64-v3 (avx/avx2/fma).
However @ghyls maybe want to try both to check if there is an actual difference in performance.
There was a problem hiding this comment.
if we enable vectorization for ucx then both x86-64-v2 and x86-64-v3 (default) will be available in CMSSW env and then at rumtime scram will pick up the best microarch lib to use of one can explicitly use non-default v2 if needed
|
please test lets run tests (just in case @ghyls want to test it locally) |
|
by the way, |
|
@ghyls was suggesting to have two builds (now with vectorisation, three): one with debug flags and one without debug flags and full optimisations. I think we could keep |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b4c9ec/54069/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
|
closing it in favor of #10663 |
4 participants
No description provided.