Skip to content

fix(auth): create OAuth client auth lazily so empty secrets don't crash module load #1053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
flipvh merged 1 commit into from
Aug 14, 2026
Merged

fix(auth): create OAuth client auth lazily so empty secrets don't crash module load #1053

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion backend/src/modules/auth/oauth/helpers/providers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ const createProviderClient = ({
resolveIssuerFromIdToken,
}: ProviderSetup) => {
const client: oauth.Client = { client_id: clientId };
const clientAuth = oauth.ClientSecretPost(clientSecret);

return {
/** Builds the provider authorization URL with state, scopes, and an optional PKCE challenge + OIDC nonce. */
Expand Down Expand Up @@ -92,6 +91,9 @@ const createProviderClient = ({
{ codeVerifier, nonce }: OAuthFlowContext = {},
): Promise<{ accessToken: string }> {
try {
// Created lazily: ClientSecretPost rejects empty secrets, and they may legitimately be
// absent at module load (CI openapi generation, deployments without this provider)
const clientAuth = oauth.ClientSecretPost(clientSecret);
const callbackParams = oauth.validateAuthResponse(as, client, new URLSearchParams({ code, state }), state);
const response = await oauth.authorizationCodeGrantRequest(
as,
Expand Down