fix(auth): create OAuth client auth lazily so empty secrets don't crash module load - #1053
Merged
Conversation
…sh module load oauth4webapi's ClientSecretPost rejects empty secrets, unlike arctic's constructors. providers.ts called it at module load, so any context without OAuth secrets (CI openapi generation on the release PR, forks or deployments without a provider configured) crashed on import. Construct it inside validateAuthorizationCode instead: a missing secret now fails only that provider's code exchange, matching pre-migration behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release-please PR (#1044) fails CI at the "Generate OpenAPI spec" step:
TypeError: "clientSecret" must not be empty. Regression from #1052 —oauth4webapi'sClientSecretPostvalidates eagerly (arctic's constructors accepted empty strings), andproviders.tscalled it at module load. Any context without OAuth secrets crashes on import: CI openapi generation, and any fork/deployment booting without all three providers configured.What
Move the
ClientSecretPostcall insidevalidateAuthorizationCode. A missing secret now fails only that provider's code exchange (mapped tooauth_failed), which matches pre-migration behavior. No other behavior change.Test plan
generate:openapiwith empty*_CLIENT_SECRETenv fails on main's code, passes with this fix🤖 Generated with Claude Code