Skip to content

feat: add Node.js concurrency example #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wolfeidau wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add Node.js concurrency example #99

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .buildkite/examples.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ steps:
value: "artifacts"
- label: "Advanced delivery"
value: "advanced"
- label: "Node.js concurrency"

@buildsworth-bk-app buildsworth-bk-app Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: Adding this fourth option currently breaks TestExamplesPipelineSelectsOneCanonicalWorkflow, whose exact option contract still contains only the original three entries. I reproduced this with go test ./...; please update the contract test for the new selector so the required test gate passes.

@buildsworth-bk-app buildsworth-bk-app Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still open — go test ./... continues to fail in TestExamplesPipelineSelectsOneCanonicalWorkflow because its expected options omit the new selector.

value: "nodejs-concurrency"

- label: ":pipeline: Load example workflow"
key: "example-loader"
Expand All @@ -43,6 +45,9 @@ steps:
advanced)
workflow=".github/workflows/example-advanced.yml"
;;
nodejs-concurrency)
workflow=".github/workflows/example-nodejs-concurrency.yml"
;;
*)
echo "unknown example: $$example" >&2
exit 2
Expand Down
7 changes: 6 additions & 1 deletion .buildkite/upload-examples.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
set -euo pipefail

if (( $# > 1 )); then
echo 'usage: .buildkite/upload-examples.sh [basic|artifacts|advanced]' >&2
echo 'usage: .buildkite/upload-examples.sh [basic|artifacts|advanced|nodejs-concurrency]' >&2
exit 2
fi

Expand Down Expand Up @@ -40,6 +40,8 @@ steps:
value: "artifacts"
- label: "Advanced delivery"
value: "advanced"
- label: "Node.js concurrency"
value: "nodejs-concurrency"

- label: ":pipeline: Load example workflow"
key: "example-loader"
Expand All @@ -64,6 +66,9 @@ case "$example" in
advanced)
workflow=".github/workflows/example-advanced.yml"
;;
nodejs-concurrency)

@buildsworth-bk-app buildsworth-bk-app Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: scripts/compare-example still rejects nodejs-concurrency, even though it mirrors every existing example selector and is the documented paired Actions/Buildkite launcher. Adding the corresponding case there would make this workflow available through the same comparison path.

workflow=".github/workflows/example-nodejs-concurrency.yml"
;;
*)
echo "unknown example: $example" >&2
exit 2
Expand Down
27 changes: 27 additions & 0 deletions .github/workflows/example-nodejs-concurrency.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
name: Example - basic nodejs CI

on:
workflow_dispatch:

permissions:
contents: read

env:
POC_SUITE: basic

concurrency:
group: ci-${{ github.ref }}
cancel-in-progress: true

jobs:
build-check-test:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1

- name: Setup Node.js
uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0
Comment thread
buildsworth-bk-app[bot] marked this conversation as resolved.
with:
node-version: 22
cache: npm

@buildsworth-bk-app buildsworth-bk-app Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: Enabling npm caching makes setup-node search GITHUB_WORKSPACE for package-lock.json, npm-shrinkwrap.json, or yarn.lock; this repository has none, and setup-node throws Dependencies lock file is not found.... The example therefore fails in this step even after importer admission is fixed. Please either add the dependency project/lockfile this example is meant to cache or remove cache: npm.

@buildsworth-bk-app buildsworth-bk-app Bot Aug 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still open — the repository has no package-lock.json, npm-shrinkwrap.json, or yarn.lock, so this explicit npm cache path still fails during setup-node.

Loading