feat: add Node.js concurrency example - #99
Conversation
28487b6 to
229fb2d
Compare
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are three blockers in the new example path: the selector currently breaks an existing contract test, and the workflow cannot complete either Buildkite preparation or Node setup.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 13435, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
About buildsworth
Model: gpt-5.6-sol with xhigh thinking.
How to request a review: Comment @buildsworth-bk review on the PR, or request buildsworth-bk as a reviewer.
Risk labels (how buildsworth classifies risk) — buildsworth classifies risk itself from the diff. To let it approve, grant L2 approval by mentioning @buildsworth-bk (see L2 approval grant):
- L1 — Low risk (dep bumps, docs/copy, lockfiles, small presentational fixes). buildsworth may approve by default.
- L2 — Standard risk (new UI, additive API fields, refactors). Approved only with an L2 grant; otherwise comment-only.
- L3 — High risk (auth, migrations, payments, secrets, perf-critical paths). Human review always required.
| value: "artifacts" | ||
| - label: "Advanced delivery" | ||
| value: "advanced" | ||
| - label: "Node.js concurrency" |
There was a problem hiding this comment.
Blocking: Adding this fourth option currently breaks TestExamplesPipelineSelectsOneCanonicalWorkflow, whose exact option contract still contains only the original three entries. I reproduced this with go test ./...; please update the contract test for the new selector so the required test gate passes.
There was a problem hiding this comment.
Still open — go test ./... continues to fail in TestExamplesPipelineSelectsOneCanonicalWorkflow because its expected options omit the new selector.
| uses: actions/setup-node@820762786026740c76f36085b0efc47a31fe5020 # v7.0.0 | ||
| with: | ||
| node-version: 22 | ||
| cache: npm |
There was a problem hiding this comment.
Blocking: Enabling npm caching makes setup-node search GITHUB_WORKSPACE for package-lock.json, npm-shrinkwrap.json, or yarn.lock; this repository has none, and setup-node throws Dependencies lock file is not found.... The example therefore fails in this step even after importer admission is fixed. Please either add the dependency project/lockfile this example is meant to cache or remove cache: npm.
There was a problem hiding this comment.
Still open — the repository has no package-lock.json, npm-shrinkwrap.json, or yarn.lock, so this explicit npm cache path still fails during setup-node.
229fb2d to
efb43ce
Compare
There was a problem hiding this comment.
One prior blocker is resolved by the rebase, while the selector contract and npm cache failures remain open. I also found one non-blocking integration gap in the paired launcher.
Want to dig deeper?
Paste this into your agent to explore the findings from this review's Buildkite build:
Download the buildsworth logs from build 13505, then answer my questions about the findings.
Install the reading-buildsworth-logs skill to run this.
| advanced) | ||
| workflow=".github/workflows/example-advanced.yml" | ||
| ;; | ||
| nodejs-concurrency) |
There was a problem hiding this comment.
Non-blocking: scripts/compare-example still rejects nodejs-concurrency, even though it mirrors every existing example selector and is the documented paired Actions/Buildkite launcher. Adding the corresponding case there would make this workflow available through the same comparison path.
1 participant
No description provided.