Skip to content

Bump spirit to @main (16c62ef306a1) - #26

Open
morgo wants to merge 1 commit into
block:mainfrom
morgo:bump-spirit-main-20260914
Open

morgo wants to merge 1 commit into
block:mainfrom
morgo:bump-spirit-main-20260914

Conversation

@morgo

@morgo morgo commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Bumps github.com/block/spirit to the current main (16c62ef306a1), and
github.com/block/mysql to ee0a93fe50d6 to match what spirit now requires.

Supersedes #25, which was opened at spirit 1ab2595e45a1 and predates
main's move to the block/mysql driver (#24). This branch is built fresh on
current upstream/main, so #25 can be closed.

Range since polt's previous pin (dc3d4c9f4c3b..16c62ef306a1)

  • 10804bbe247c — dbconn: take RDS TLS from the driver, and drop rejectReadOnly (#1221)
  • a31c0ecc9544 — Enable depguard to keep exactly one MySQL driver linked (#1222)
  • 2d48942b5f91 — feat(move): add host-aware autoscaling for sharded moves (#1216)
  • 1ab2595e45a1 — fix(statement): fold TRUE/FALSE keyword defaults on integer columns (#1224)
  • 16c62ef306a1 — fix(dbconn): read tinyint(1) as an integer, not a bool (#1226)

Checked for downstream impact, none found:

  • rejectReadOnly removal (#1221) — grepped for RejectReadOnly: zero hits.
  • The depguard lint (#1222) is spirit-internal; it does not constrain consumers.
  • tinyint(1) (#1226) is applied inside newDSN, so it reaches connections
    opened through dbconn.New. A consumer calling dbconn.EnhanceDSNWithTLS
    and opening the DSN itself does not inherit it — polt has no
    EnhanceDSNWithTLS call sites.
  • #1216 touches pkg/move/pkg/copier/pkg/host/pkg/applier without
    changing the APIs polt uses (table.NewChunker, the change interfaces).

Verification

  • go.mod / go.sum only — zero source changes.
  • ./bin/go build ./... clean.
  • ./bin/go vet ./... clean (type-checks test files too).
  • No replace line added, removed or changed; spirit main itself has none.
  • Hermit toolchain is already go 1.26.6, matching spirit's go directive — no
    hermit rebuild in this PR.

🤖 Generated with Claude Code

Copilot AI lite review requested due to automatic review settings September 14, 2026 15:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Moving dependency pins warrant final human review despite clean verification.

Pull request overview

Updates Spirit and the matching Block MySQL dependency to newer commits without source changes.

Changes:

  • Bumps dependency pins.
  • Refreshes module checksums.
File summaries
File Description
go.sum Updates dependency checksums.
go.mod Updates dependency pins.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants