Conversation
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Moving dependency pins warrant final human review despite clean verification.
Pull request overview
Updates Spirit and the matching Block MySQL dependency to newer commits without source changes.
Changes:
- Bumps dependency pins.
- Refreshes module checksums.
File summaries
| File | Description |
|---|---|
go.sum |
Updates dependency checksums. |
go.mod |
Updates dependency pins. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
github.com/block/spiritto the currentmain(16c62ef306a1), andgithub.com/block/mysqltoee0a93fe50d6to match what spirit now requires.Supersedes #25, which was opened at spirit
1ab2595e45a1and predatesmain's move to theblock/mysqldriver (#24). This branch is built fresh oncurrent
upstream/main, so #25 can be closed.Range since polt's previous pin (
dc3d4c9f4c3b..16c62ef306a1)10804bbe247c— dbconn: take RDS TLS from the driver, and droprejectReadOnly(#1221)a31c0ecc9544— Enable depguard to keep exactly one MySQL driver linked (#1222)2d48942b5f91— feat(move): add host-aware autoscaling for sharded moves (#1216)1ab2595e45a1— fix(statement): fold TRUE/FALSE keyword defaults on integer columns (#1224)16c62ef306a1— fix(dbconn): read tinyint(1) as an integer, not a bool (#1226)Checked for downstream impact, none found:
rejectReadOnlyremoval (#1221) — grepped forRejectReadOnly: zero hits.tinyint(1)(#1226) is applied insidenewDSN, so it reaches connectionsopened through
dbconn.New. A consumer callingdbconn.EnhanceDSNWithTLSand opening the DSN itself does not inherit it — polt has no
EnhanceDSNWithTLScall sites.pkg/move/pkg/copier/pkg/host/pkg/applierwithoutchanging the APIs polt uses (
table.NewChunker, thechangeinterfaces).Verification
./bin/go build ./...clean../bin/go vet ./...clean (type-checks test files too).replaceline added, removed or changed; spiritmainitself has none.godirective — nohermit rebuild in this PR.
🤖 Generated with Claude Code