Bump spirit to @main (1ab2595e45a1) - #25
Open
morgo wants to merge 1 commit into
Open
Conversation
Bumps github.com/block/spirit to 1ab2595e45a1 (latest main). Also picks up github.com/block/mysql ee0a93fe50d6 to match.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Dependency updates were reviewed with no unresolved blocking issues.
Pull request overview
Updates Spirit and its MySQL driver dependency to newer commits, with no application source changes.
Changes:
- Bumps
github.com/block/spirit. - Bumps
github.com/block/mysql. - Refreshes dependency checksums.
File summaries
| File | Description |
|---|---|
go.sum |
Refreshes dependency checksums. |
go.mod |
Updates dependency versions. |
Review details
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
github.com/block/spiritto the latestmaincommit,1ab2595e45a1.Range picked up since the previous pin:
rejectReadOnlygo.mod/go.sumonly — no source changes were required.Notes on the MySQL driver change (#1219)
Spirit now depends on
github.com/block/mysqldirectly by its own module path and has droppedgithub.com/go-sql-driver/mysqlfrom itsgo.modentirely. Spirit itself now carries zeroreplacedirectives, so there is nothing to mirror downstream this bump (git diff -U0 -- go.mod | grep -E 'replace|=>'is empty).This is safe with respect to the classic double-registration hazard: the fork registers itself as
block-mysql, notmysql(driver.go), precisely so that a build still reaching upstreamgo-sql-driverdoes not panic at init with twosql.Registercalls under one name. Verifiedgo list -mprints plain versions with no=>for spirit,block/mysql,go-mysql-org/go-mysqlandgo-sql-driver/mysql.Verification
go build ./...cleango vet ./...clean (type-checks test files, so it catches stale API use a plain build misses)rejectReadOnlyknobgodirective