Skip to content

Bump spirit to @main (1ab2595e45a1) - #25

Open
morgo wants to merge 1 commit into
block:mainfrom
morgo:bump-spirit-main-20260910
Open

Bump spirit to @main (1ab2595e45a1)#25
morgo wants to merge 1 commit into
block:mainfrom
morgo:bump-spirit-main-20260910

Conversation

@morgo

@morgo morgo commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Bumps github.com/block/spirit to the latest main commit, 1ab2595e45a1.

Range picked up since the previous pin:

  • #1219 Use the block-mysql driver
  • #1221 dbconn: take RDS TLS from the driver, and drop rejectReadOnly
  • #1222 Enable depguard to keep exactly one MySQL driver linked
  • #1216 feat(move): host-aware autoscaling for sharded moves
  • #1224 fix(statement): fold TRUE/FALSE keyword defaults on integer columns

go.mod/go.sum only — no source changes were required.

Notes on the MySQL driver change (#1219)

Spirit now depends on github.com/block/mysql directly by its own module path and has dropped github.com/go-sql-driver/mysql from its go.mod entirely. Spirit itself now carries zero replace directives, so there is nothing to mirror downstream this bump (git diff -U0 -- go.mod | grep -E 'replace|=>' is empty).

This is safe with respect to the classic double-registration hazard: the fork registers itself as block-mysql, not mysql (driver.go), precisely so that a build still reaching upstream go-sql-driver does not panic at init with two sql.Register calls under one name. Verified go list -m prints plain versions with no => for spirit, block/mysql, go-mysql-org/go-mysql and go-sql-driver/mysql.

Verification

  • go build ./... clean
  • go vet ./... clean (type-checks test files, so it catches stale API use a plain build misses)
  • No downstream use of the removed rejectReadOnly knob
  • Toolchain already 1.26.6, matching spirit main's go directive

Bumps github.com/block/spirit to 1ab2595e45a1 (latest main).
Also picks up github.com/block/mysql ee0a93fe50d6 to match.
Copilot AI lite review requested due to automatic review settings September 10, 2026 23:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Dependency updates were reviewed with no unresolved blocking issues.

Pull request overview

Updates Spirit and its MySQL driver dependency to newer commits, with no application source changes.

Changes:

  • Bumps github.com/block/spirit.
  • Bumps github.com/block/mysql.
  • Refreshes dependency checksums.
File summaries
File Description
go.sum Refreshes dependency checksums.
go.mod Updates dependency versions.
Review details
  • Files reviewed: 1/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants