feat(checkout): CHECKOUT-10352 Add support for isPhoneNumberValidation setting - #3380
Draft
bc-maxy wants to merge 1 commit into
Draft
feat(checkout): CHECKOUT-10352 Add support for isPhoneNumberValidation setting#3380bc-maxy wants to merge 1 commit into
bc-maxy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
I'm adding support for phone validation option in checkout-settings-ui:
https://github.com/bigcommerce/bigcommerce/pull/69835
https://github.com/bigcommerce/checkout-settings-ui/pull/157
And this PR builds on top of it and threads the setting through sdk so that we can use it on checkout-js side.
Rollout/Rollback
Revert the PR
Testing
Just a type extension + some mock changes. Made the property optional so that it doesn't break anything.