feat(checkout): CHECKOUT-10352 Swap phone LD experiment with a checkout setting - #3287
Draft
bc-maxy wants to merge 1 commit into
Draft
feat(checkout): CHECKOUT-10352 Swap phone LD experiment with a checkout setting#3287bc-maxy wants to merge 1 commit into
bc-maxy wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Once we merge the SDK side: bigcommerce/checkout-sdk-js#3380
We can then just use a checkout setting instead of a LD flag to control rendering of new phone validation.
Since this is a controlled rollout which customers can opt-in or -out themselves, I also removed all other restrictions that we had previously in place like not rendering the component for Paypal Braintree merchants or not rendering when merchants set maxLength limits or placeholders on phone input fields.
Rollout/Rollback
Revert the PR
Testing
Updated CI tests.