Repository navigation
chore(deps): run on built_collection 6.0.0 via a git override #169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,13 @@ | ||
| dependency_overrides: | ||
| zorphy_annotation: | ||
| path: ../zorphy_annotation | ||
| # built_value 8.13.0 still pins built_collection ^5.0.0, which is the sole | ||
| # blocker for 6.0.0 (google/built_value.dart#1405). The widening is in | ||
| # google/built_value.dart#1406; until a release carries it, resolve against | ||
| # that branch so CI exercises the 6.0.0 graph. Development-only: pub ignores | ||
| # this file, so consumers still resolve whatever built_value allows. | ||
| built_value: | ||
| git: | ||
| url: https://github.com/arrrrny/built_value.dart | ||
| ref: widen-built-collection-1405 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔵 Non-blocking (📐 maintainability): |
||
| path: built_value | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔵 Nit (📐 clarity): here it reads "The widening is in google/built_value.dart#1406" (present tense, as if already merged), while
pubspec.yamlcorrectly says "is proposed in". The branch itself says "Fixes #1405" and the PR is #1406. Consider e.g. "proposed in #1406 (branchwiden-built-collection-1405, fixes #1405)" to keep the cross-references unambiguous.