Verify the build against Maven 4 as well - #1350
Closed
slachiewicz wants to merge 1 commit into
Closed
Conversation
Set maven4-enabled so the shared verify workflow adds the Maven 4 version to the build matrix next to 3.10.0-rc-1. The jdk 8 / Maven 4 combination is excluded by the shared workflow itself. Also drop the trailing comma from matrix-exclude: with maven4-enabled the shared workflow pipes that value through jq to append its own exclusion, and jq rejects the trailing comma.
This was referenced Aug 4, 2026
Contributor
|
Duplicate of #1323 But no strong opinion on what to keep. 1323 has some analytics on why it fails with (before rc6) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plugin is currently only verified against Maven 3. Adding
maven4-enabled: truemakes the shared verify workflow put the Maven 4 version into the build matrix alongside3.10.0-rc-1, so regressions under Maven 4 show up here instead of downstream. The shared workflow adds thejdk: 8/ Maven 4 exclusion by itself, so nothing else has to change in the matrix.The trailing comma in
matrix-excludehas to go at the same time. Withoutmaven4-enabledthat value is echoed verbatim, so the invalid JSON went unnoticed; with the flag on, the shared workflow pipes it throughjqto append its own exclusion, andjqrejects it:Verified locally with Maven 4.0.0-rc-6 on JDK 21:
clean verifysucceeds and all unit tests pass.