Skip to content

Verify the build against Maven 4 as well - #330

Merged
slachiewicz merged 1 commit into
apache:masterfrom
slachiewicz:ci-verify-maven4
Aug 8, 2026
Merged

Verify the build against Maven 4 as well#330
slachiewicz merged 1 commit into
apache:masterfrom
slachiewicz:ci-verify-maven4

Conversation

@slachiewicz

Copy link
Copy Markdown
Member

Adds maven4-enabled: true, which appends 4.0.0-rc-6 to the existing Maven 3 matrix rather than replacing it — so the plugin keeps being built and tested with Maven 3 and additionally gets verified against Maven 4. The shared workflow also excludes the {jdk: 8, maven: 4.x} cell automatically, since Maven 4 needs JDK 17+.

Part of establishing which Maven 3 plugins already build clean on Maven 4 ahead of the 4.0.0 GA. Same change as apache/maven-javadoc-plugin#1350. Context in apache/maven#12676.

If the Maven 4 cell turns out to fail, that is the useful result — better to know now than at GA.

@slachiewicz

Copy link
Copy Markdown
Member Author

The Maven 4 leg this enables is red for a reason unrelated to the workflow: sign-release-with-excludes does not know about the build POM that Maven 4 installs next to the consumer POM. #332 fixes the IT; once that lands this should go green on a rerun.

Two other things worth folding in here, from reviewing the run:

  • verify-fail-fast: false — the shared workflow defaults it to true, so the single Maven 4 failure cancelled the other 14 legs, including every Maven 3 one. All 15 checks read as failed when only one actually did, which makes it impossible to tell a Maven 4 problem from a Maven 3 regression.
  • maven4-version: 4.0.0-rc-6 — without it this tracks the shared workflow's floating default, so a v5 retag can change what is being verified with no commit in this repo.

I can push both to this branch if you would like.

Adds maven4-enabled, which appends the Maven 4 version to the existing
Maven 3 matrix rather than replacing it, so the plugin keeps being built
and tested with Maven 3 and additionally gets checked against 4.0.0-rc-6.

Part of finding out which Maven 3 plugins already build clean on Maven 4
ahead of the 4.0.0 GA.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@slachiewicz
slachiewicz merged commit b5ebfff into apache:master Aug 8, 2026
17 checks passed
@slachiewicz
slachiewicz deleted the ci-verify-maven4 branch August 8, 2026 09:15
@github-actions github-actions Bot added this to the 3.2.9 milestone Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant