Skip to content

fix(ui): handle non-JSON AnalysisRun measurement values #6787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SuyogShinde942 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): handle non-JSON AnalysisRun measurement values #6787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion ui/src/features/common/analysis-modal/transforms.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ import {
metricStatusLabel,
metricSubstatus,
printableCloudWatchQuery,
printableDatadogQuery
printableDatadogQuery,
transformMeasurements
} from './transforms';
import { AnalysisStatus, FunctionalStatus } from './types';

Expand Down Expand Up @@ -559,4 +560,19 @@ describe('analysis modal transforms', () => {
tableValue: { latency: null, cpuUsage: null }
});
});

test('transformMeasurements() with a plain, non-JSON string measurement value', () => {
expect(transformMeasurements([], [{ value: 'kargo' }])).toEqual({
chartable: false,
min: 0,
max: null,
measurements: [
{
value: 'kargo',
chartValue: undefined,
tableValue: 'kargo'
}
]
});
});
});
12 changes: 11 additions & 1 deletion ui/src/features/common/analysis-modal/transforms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,17 @@ const transformMeasurementValue = (
};
}

const parsedValue = JSON.parse(value);
let parsedValue;
try {
parsedValue = JSON.parse(value);
} catch {
// providers such as web can return a plain, non-JSON string (e.g. "ok") --
// display it as-is rather than failing to render the measurement
return {
canChart: false,
tableValue: value
};
}

// single number measurement value
if (isFiniteNumber(parsedValue)) {
Expand Down