fix(ui): handle non-JSON AnalysisRun measurement values - #6787
Open
SuyogShinde942 wants to merge 1 commit into
Open
fix(ui): handle non-JSON AnalysisRun measurement values#6787SuyogShinde942 wants to merge 1 commit into
SuyogShinde942 wants to merge 1 commit into
Conversation
Metric providers such as web can return a plain-text response instead of JSON. JSON.parse() throws in that case, which crashes the useMemo() computing the analysis chart/table data and leaves the AnalysisRun panel unable to open. Catch the parse failure and fall back to displaying the raw value in the table (as an unsupported/non-chartable format), matching how other unsupported value shapes are already handled. Fixes akuity#6785 Signed-off-by: Suyog Shinde <suyog942.shinde@gmail.com>
✅ Deploy Preview for docs-kargo-io ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kargo-governance-bot
Bot
added
kind/bug
Author
|
With this fix applied, the modal renders normally and shows the raw value in the measurement table instead of crashing: |
Contributor
|
There is already a PR open similar to this #6758 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transformMeasurementValue()in the analysis modal calledJSON.parse()on every metric measurement value unconditionally. Providers such aswebcan return a plain-text response (not JSON), which throws inside theuseMemo()that builds the AnalysisRun chart/table data and leaves the panel unable to open (a brief "flash" with no further UI, per the console error in the issue).Fixes #6785
Test plan
pnpm typecheckpnpm lint(targeted eslint run on changed files)pnpm test(vitest run) — 187/187 passing, including new test case