refactor: use TensorDict NestedKey directly - #134
Merged
Merged
Conversation
There was a problem hiding this comment.
No issues found across 19 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Refactor swaps the internal UnraveledKey alias for TensorDict's NestedKey across type signatures, imports, and tests, and removes the now-unused alias definition. No behavioral change is introduced; it is a bounded, clearly beneficial cleanup backed by comprehensive tests.
Re-trigger cubic
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 98.45% 98.45%
=======================================
Files 54 54
Lines 4336 4340 +4
=======================================
+ Hits 4269 4273 +4
Misses 67 67 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the internal key compatibility alias with
tensordict.utils.NestedKeythroughout library signatures and tests. Remove the alias from_types.pyand update the file-structure reference to describe the remaining helpers. Key validation and composition behavior are unchanged.Fixes #132.
Validation on Python 3.12.13, TensorDict 0.14.0 and PyTorch 2.13.0:
git diff --checkpassed.The full notebook/integration suite was not run.