Skip to content

Convert ASSERTION_METHODS array to Set for O(1) lookup performance #7727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Convert ASSERTION_METHODS array to Set for O(1) lookup performance #7727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/analysis/src/jsts/rules/helpers/testing/cypress.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import type estree from 'estree';
import { isIdentifier } from '../ast.js';
import ts from 'typescript';

const ASSERTION_METHODS = ['should', 'and'];
const ASSERTION_METHODS = new Set(['should', 'and']);

/**
* Detects Cypress assertion calls on the global `cy` chain, e.g.:
Expand Down Expand Up @@ -48,7 +48,7 @@ export function isTSAssertion(node: ts.Node): boolean {
return false;
}
const member = call.expression as ts.PropertyAccessExpression;
if (!ASSERTION_METHODS.includes(member.name.text)) {
if (!ASSERTION_METHODS.has(member.name.text)) {
return false;
}
return tsChainStartsWithCy(member.expression);
Expand Down