Convert ASSERTION_METHODS array to Set for O(1) lookup performance

[sonarqube-agent]

This PR was automatically created by the Remediation Agent's Scheduled backlog remediation feature.

Why these issues? This is a well-scoped, single-issue fix with clear automation guidance from SonarQube's explicit recommendation to use Set over array for membership checking. The change is localized to a specific file, has straightforward correctness verification, and provides measurable performance benefits for a commonly-used utility in the testing framework.

This change converts the ASSERTION_METHODS variable from an array literal to a Set in the cypress.ts testing helper, enabling O(1) existence checks via Set#has() instead of O(n) Array#includes() operations. This performance improvement addresses a SonarQube code smell and aligns the code with recommended best practices for membership testing.

View Project in SonarCloud

---

Fixed Issues

typescript:S7776 - `ASSERTION_METHODS` should be a `Set`, and use `ASSERTION_METHODS.has()` to check existence or non-existence. • MINOR • View issue

Location: packages/analysis/src/jsts/rules/helpers/testing/cypress.ts:21

Why is this an issue?

Using Array#includes() for existence checks can lead to performance problems, especially with larger datasets.

What changed

Converts the ASSERTION_METHODS variable from an array literal to a Set by wrapping it with new Set(...). This directly addresses the code smell at line 21 of cypress.ts where the static analysis warns that ASSERTION_METHODS should be a Set and should use Set#has() instead of Array#includes() for existence checking, improving performance from O(n) to O(1).

--- a/packages/analysis/src/jsts/rules/helpers/testing/cypress.ts
+++ b/packages/analysis/src/jsts/rules/helpers/testing/cypress.ts
@@ -21,1 +21,1 @@ import ts from 'typescript';
-const ASSERTION_METHODS = ['should', 'and'];
+const ASSERTION_METHODS = new Set(['should', 'and']);

Have a suggestion or found an issue? Share your feedback here.

---

SonarQube Remediation Agent uses AI. Check for mistakes.