Skip to content

Revert "Revert "Revert "Update resources change request payload to match phones""" #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richardxia merged 1 commit into from
May 7, 2026
Merged

Revert "Revert "Revert "Update resources change request payload to match phones""" #1462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions app/pages/OrganizationEditPage.tsx
View file
Open in desktop

@Anchellon Anchellon May 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.
We are going back to what was before changes in this commit (#1453)

Original file line number Diff line number Diff line change
Expand Up @@ -1559,48 +1559,45 @@ class OrganizationEditPage extends React.Component<Props, State> {
const promises: Promise<unknown>[] = [];

// Resource
const field_changes: Partial<Organization> = {};
const resourceChangeRequest: Partial<Organization> = {};
let resourceModified = false;
if (name !== resource.name) {
field_changes.name = name;
resourceChangeRequest.name = name;
resourceModified = true;
}
if (long_description !== resource.long_description) {
field_changes.long_description = long_description;
resourceChangeRequest.long_description = long_description;
resourceModified = true;
}
if (short_description !== resource.short_description) {
field_changes.short_description = short_description;
resourceChangeRequest.short_description = short_description;
resourceModified = true;
}
if (website !== resource.website) {
field_changes.website = website;
resourceChangeRequest.website = website;
resourceModified = true;
}
if (email !== resource.email) {
field_changes.email = email;
resourceChangeRequest.email = email;
resourceModified = true;
}
if (alternate_name !== resource.alternate_name) {
field_changes.alternate_name = alternate_name;
resourceChangeRequest.alternate_name = alternate_name;
resourceModified = true;
}
if (legal_status !== resource.legal_status) {
field_changes.legal_status = legal_status;
resourceChangeRequest.legal_status = legal_status;
resourceModified = true;
}
if (internal_note !== resource.internal_note) {
field_changes.internal_note = internal_note;
resourceChangeRequest.internal_note = internal_note;
resourceModified = true;
}
// fire off resource request
if (resourceModified) {
promises.push(
dataService.post(`/api/v2/resources/${resource.id}/change_requests`, {
change_request: {
field_changes,
action: ACTION_EDIT,
},
dataService.post(`/api/resources/${resource.id}/change_requests`, {
change_request: resourceChangeRequest,
})
);
}
Expand Down
Loading