CherryPicked: [cnv-4.22] Remove redundant and duplicated by upstream t2 tests by cnv-tests-github-webhook-dollierp[bot] · Pull Request #5933 · RedHatQE/openshift-virtualization-tests

cnv-tests-github-webhook-dollierp · 2026-08-06T10:46:16Z

Cherry-pick from main branch, original PR: #5902, PR owner: OhadRevah

Summary by CodeRabbit

Tests
- Removed coverage for default launcher update strategies and uninstall behavior.
- Removed validation of relationship labels across CNV resources.
- Removed strict reconciliation tests for operator defaults and stanza restoration.
- Removed related test fixtures, helpers, and shared validation constants.

##### What this PR does / why we need it: Remove tests that validate the same behavior already covered by upstream HCO func-tests (t1), per T2 package evaluation. strict_reconciliation/test_hco_cr_defaults_on_stanza_deletion.py: Remove test_certconfig_defaults_on_stanza_delete (CNV-6377-6393) and test_livemigrationconfig_defaults_on_stanza_delete (CNV-6403-6417). Duplicated by defaults_test.go certConfig (L32-65) and liveMigrationConfig (L102-133): https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/tests/func-tests/defaults_test.go#L32-L133 Keep test_featuregates_defaults_on_stanza_delete (CNV-6397, CNV-6399). strict_reconciliation/test_operator_defaults.py: Remove entire file — static reads of default values against hardcoded constants, covered by defaults_test.go. launcher_updates/test_default_launcher_updates.py: Remove static default value reads (CNV-6911, CNV-6912), covered by defaults_test.go workloadUpdateStrategy (L194-228): https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/tests/func-tests/defaults_test.go#L194-L228 product_uninstall/test_remove_kubevirt.py: Remove test_validate_default_uninstall_strategy (CNV-3738), covered by defaults_test.go uninstallStrategy (L216-245): https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/tests/func-tests/defaults_test.go#L216-L245 Remove dead expected_certconfig_stanza and unused imports from strict_reconciliation/utils.py. assisted by: claude code claude-opus-4-6 ##### Which issue(s) this PR fixes: ##### Special notes for reviewer: ##### jira-ticket:   ## Summary by CodeRabbit - **Tests** - Removed outdated validation coverage for default workload update and uninstall strategies. - Removed strict-reconciliation tests covering operator defaults, certificate settings, feature gates, and live-migration configuration. - Removed unused test fixtures and helper utilities related to deleted scenarios.  Signed-off-by: Ohad Revah <orevah@redhat.com>

openshift-virtualization-qe-bot-3 · 2026-08-06T10:52:18Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified
Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (PR author or approvers)
/hold cancel - Unblock PR merging (PR author or approvers)
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
/regenerate-welcome - Regenerate this welcome message
/security-override - Set security check runs to pass (maintainers only)
/security-override cancel - Re-run security checks

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest build-container - Rebuild and test container image
/retest verify-bugs-are-open - verify-bugs-are-open
/retest all - Run all available tests

Container Operations

/build-and-push-container - Build and push container image (tagged with PR number)
- Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3
/cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

/rebase - Rebase this PR branch onto its base branch

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
LGTM Count: Minimum 2 /lgtm from reviewers
Status Checks: All required status checks must pass
No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

dshchedr
myakove
rnetser
vsibirsk

Reviewers:

OhadRevah
RoniKishner
albarker-rh
dshchedr
hmeir
rlobillo
rnetser
vsibirsk

Available Labels

hold
verified
wip
lgtm
approve

AI Features

Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)

Security Checks

Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
Committer Identity Check: Verifies last committer matches PR author
Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Container Builds: Container images are automatically tagged with the PR number
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

📌 Additional Information

Custom Commands:

/test-plan — Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan
/rerun-smoke — Adds retest-smoke label on the PR to trigger smoke tests execution

For more information, please refer to the project documentation or contact the maintainers.

rnetser · 2026-08-06T16:33:51Z

@coderabbitai review

coderabbitai · 2026-08-06T16:33:55Z

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-08-06T16:33:58Z

📝 Walkthrough

Walkthrough

The pull request deletes redundant operator validation tests and their supporting fixtures, constants, and helpers. The removed coverage includes launcher updates, product uninstall behavior, relationship labels, and strict reconciliation defaults.

Changes

Operator test cleanup

Layer / File(s)	Summary
Default strategy validation removal `tests/install_upgrade_operators/launcher_updates/test_default_launcher_updates.py`, `tests/install_upgrade_operators/product_uninstall/test_remove_kubevirt.py`	Removes tests for default workload update and uninstall strategies.
Relationship-label validation removal `tests/install_upgrade_operators/relationship_labels/constants.py`, `tests/install_upgrade_operators/relationship_labels/test_all_cnv_resources.py`	Removes the aggregate label-key constant and CNV resource relationship-label validation helpers, fixtures, and test.
Strict-reconciliation coverage removal `tests/install_upgrade_operators/strict_reconciliation/conftest.py`, `tests/install_upgrade_operators/strict_reconciliation/test_hco_cr_defaults_on_stanza_deletion.py`, `tests/install_upgrade_operators/strict_reconciliation/test_operator_defaults.py`, `tests/install_upgrade_operators/strict_reconciliation/utils.py`	Removes the resource mapping fixture, default reconciliation test modules, and certificate-configuration helper.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

RedHatQE/openshift-virtualization-tests#5839: Removes redundant install/upgrade operator tests and supporting definitions.
RedHatQE/openshift-virtualization-tests#5902: Deletes the same tests, fixtures, constants, and helper functions.

Suggested reviewers: dshchedr, ronikishner, vsibirsk

Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

Ignore

❌ Failed checks (1 error)

Check name	Status	Explanation	Resolution
Description check	❌ Error	The description identifies the cherry-picked source PR but omits all required template sections and issue or Jira details.	Add the required sections for purpose, fixed issues, reviewer notes, and jira-ticket; use NONE when no Jira ticket applies.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title is 78 characters and clearly describes removal of redundant and duplicated tests.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stp Link Required	✅ Passed	HEAD versus its parent contains 899 deletions and zero additions; no test file or test function was newly added.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch CherryPicked-remove-t1-duplicate-tests-DYagB

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

OhadRevah · 2026-08-09T06:57:34Z

/verified

rnetser · 2026-08-09T07:03:07Z

/approve
/lgtm

rnetser · 2026-08-09T13:53:04Z

@coderabbitai review

coderabbitai · 2026-08-09T13:53:08Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

openshift-virtualization-qe-bot-2 · 2026-08-10T13:58:06Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.22 published

cnv-tests-github-webhook-dollierp Bot added the CherryPicked-from-main label Aug 6, 2026

openshift-virtualization-qe-bot-6 assigned OhadRevah Aug 6, 2026

openshift-virtualization-qe-bot-6 requested a review from OhadRevah August 6, 2026 10:46

github-actions Bot added the sig-iuo label Aug 6, 2026

openshift-virtualization-qe-bot-6 mentioned this pull request Aug 6, 2026

Remove redundant and duplicated by upstream t2 tests #5902

Merged

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing tox:verify-tc-requirement-polarion:passed D/S Testing and removed tox:verify-tc-requirement-polarion:running D/S Testing labels Aug 6, 2026

openshift-virtualization-qe-bot-3 requested a review from hmeir August 6, 2026 10:52

openshift-virtualization-qe-bot-3 assigned cnv-tests-github-webhook-dollierp[bot] Aug 6, 2026

openshift-virtualization-qe-bot-3 added the branch-cnv-4.22 label Aug 6, 2026

openshift-virtualization-qe-bot-3 requested review from RoniKishner, albarker-rh and rnetser August 6, 2026 10:52

openshift-virtualization-qe-bot-3 added the size/XXL label Aug 6, 2026

openshift-virtualization-qe-bot-3 requested review from dshchedr, rlobillo and vsibirsk August 6, 2026 10:53

openshift-virtualization-qe-bot-6 added the needs-rebase label Aug 6, 2026

openshift-virtualization-qe-bot-6 added the verified label Aug 9, 2026

openshift-virtualization-qe-bot-2 added approved-rnetser lgtm-rnetser labels Aug 9, 2026

hmeir approved these changes Aug 10, 2026

View reviewed changes

openshift-virtualization-qe-bot-4 added the lgtm-hmeir label Aug 10, 2026

openshift-virtualization-qe-bot-5 added the can-be-merged label Aug 10, 2026

rnetser merged commit 91b720e into cnv-4.22 Aug 10, 2026
25 checks passed

rnetser deleted the CherryPicked-remove-t1-duplicate-tests-DYagB branch August 10, 2026 13:11

Navigation Menu

Uh oh!

CherryPicked: [cnv-4.22] Remove redundant and duplicated by upstream t2 tests - #5933

CherryPicked: [cnv-4.22] Remove redundant and duplicated by upstream t2 tests #5933
rnetser merged 1 commit into
cnv-4.22from
CherryPicked-remove-t1-duplicate-tests-DYagB

cnv-tests-github-webhook-dollierp Bot commented Aug 6, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

openshift-virtualization-qe-bot-3 commented Aug 6, 2026

Uh oh!

rnetser commented Aug 6, 2026

Uh oh!

coderabbitai Bot commented Aug 6, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 6, 2026 •

edited

Loading

Walkthrough

Changes

Pre-merge checks failed

Uh oh!

OhadRevah commented Aug 9, 2026

Uh oh!

rnetser commented Aug 9, 2026

Uh oh!

rnetser commented Aug 9, 2026

Uh oh!

coderabbitai Bot commented Aug 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

openshift-virtualization-qe-bot-2 commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

cnv-tests-github-webhook-dollierp Bot commented Aug 6, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-virtualization-qe-bot-3 commented Aug 6, 2026

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Container Operations

Cherry-pick Operations

Branch Management

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

📌 Additional Information

Uh oh!

rnetser commented Aug 6, 2026

Uh oh!

coderabbitai Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Aug 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Pre-merge checks failed

❌ Failed checks (1 error)

Uh oh!

OhadRevah commented Aug 9, 2026

Uh oh!

rnetser commented Aug 9, 2026

Uh oh!

rnetser commented Aug 9, 2026

Uh oh!

coderabbitai Bot commented Aug 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

openshift-virtualization-qe-bot-2 commented Aug 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

cnv-tests-github-webhook-dollierp Bot commented Aug 6, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 6, 2026 •

edited

Loading

coderabbitai Bot commented Aug 6, 2026 •

edited

Loading

coderabbitai Bot commented Aug 9, 2026 •

edited

Loading