Remove redundant and duplicated by upstream t2 tests

[OhadRevah]

What this PR does / why we need it:

Remove tests that validate the same behavior already covered by upstream HCO func-tests (t1), per T2 package evaluation.

strict_reconciliation/test_hco_cr_defaults_on_stanza_deletion.py:
Remove test_certconfig_defaults_on_stanza_delete (CNV-6377-6393)
and test_livemigrationconfig_defaults_on_stanza_delete (CNV-6403-6417).
Duplicated by defaults_test.go certConfig (L32-65) and
liveMigrationConfig (L102-133):
https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/tests/func-tests/defaults_test.go#L32-L133
Keep test_featuregates_defaults_on_stanza_delete (CNV-6397, CNV-6399).

strict_reconciliation/test_operator_defaults.py:
Remove entire file — static reads of default values against
hardcoded constants, covered by defaults_test.go.

launcher_updates/test_default_launcher_updates.py:
Remove static default value reads (CNV-6911, CNV-6912),
covered by defaults_test.go workloadUpdateStrategy (L194-228):
https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/tests/func-tests/defaults_test.go#L194-L228

product_uninstall/test_remove_kubevirt.py:
Remove test_validate_default_uninstall_strategy (CNV-3738),
covered by defaults_test.go uninstallStrategy (L216-245):
https://github.com/kubevirt/hyperconverged-cluster-operator/blob/main/tests/func-tests/defaults_test.go#L216-L245

Remove dead expected_certconfig_stanza and unused imports from strict_reconciliation/utils.py.

assisted by: claude code claude-opus-4-6

Which issue(s) this PR fixes:

Special notes for reviewer:

jira-ticket:

Summary by CodeRabbit

• Tests
  • Removed outdated validation coverage for default workload update and uninstall strategies.
  • Removed strict-reconciliation tests covering operator defaults, certificate settings, feature gates, and live-migration configuration.
  • Removed unused test fixtures and helper utilities related to deleted scenarios.

[coderabbitai]

Warning

Review limit reached

@OhadRevah, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b6cf6318-b722-41d4-9790-d040ab449e44

📥 Commits

Reviewing files that changed from the base of the PR and between 5851f9e and 59e641a.

📒 Files selected for processing (8)

• tests/install_upgrade_operators/launcher_updates/test_default_launcher_updates.py
• tests/install_upgrade_operators/product_uninstall/test_remove_kubevirt.py
• tests/install_upgrade_operators/relationship_labels/constants.py
• tests/install_upgrade_operators/relationship_labels/test_all_cnv_resources.py
• tests/install_upgrade_operators/strict_reconciliation/conftest.py
• tests/install_upgrade_operators/strict_reconciliation/test_hco_cr_defaults_on_stanza_deletion.py
• tests/install_upgrade_operators/strict_reconciliation/test_operator_defaults.py
• tests/install_upgrade_operators/strict_reconciliation/utils.py

📝 Walkthrough

Walkthrough

This change deletes obsolete launcher update, uninstall strategy, and strict-reconciliation tests. It also removes the unused cr_func_map fixture and the expected_certconfig_stanza helper.

Changes

Reconciliation test cleanup

Layer / File(s)	Summary
Remove obsolete test coverage tests/install_upgrade_operators/launcher_updates/*, tests/install_upgrade_operators/product_uninstall/*, tests/install_upgrade_operators/strict_reconciliation/*	Removed tests for default workload update strategies, KubeVirt uninstall strategy, operator defaults, stanza-deletion reconciliation, and related helper and fixture code.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• RedHatQE/openshift-virtualization-tests#4228: Modifies strict-reconciliation tests for live-migration configuration defaults.
• RedHatQE/openshift-virtualization-tests#5777: Modifies reconciliation fixtures in strict_reconciliation/conftest.py.

Suggested reviewers: dshchedr, rnetser, ronikishner

🚥 Pre-merge checks | ✅ 6

✅ Passed checks (6 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Pr Template Sections	✅ Passed	The live PR body includes all four required headings, and the purpose section contains meaningful text describing the test removals.
Stp Link Required	✅ Passed	The diff contains only deletions: all six changed files have 0 added lines, with no new test files or test functions.
Stp Scenario Coverage	✅ Passed	The changed test_*.py files have no module, class, or test docstrings containing STP:, Jira:, or RFE: URLs; the STP scenario coverage check is not applicable.
Title check	✅ Passed	The title is under 120 characters and accurately describes removal of redundant tests covered by upstream tests.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-virtualization-qe-bot]

Clean rebase detected — no code changes compared to previous head (480acd7).

[openshift-virtualization-qe-bot]

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

• Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
• Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
• Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
• Branch Labeling: Branch-specific labels are applied to track the target branch
• Auto-verification: Auto-verified users have their PRs automatically marked as verified
• Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

• /wip - Mark PR as work in progress (adds WIP: prefix to title)
• /wip cancel - Remove work in progress status
• /hold - Block PR merging (PR author or approvers)
• /hold cancel - Unblock PR merging (PR author or approvers)
• /verified - Mark PR as verified
• /verified cancel - Remove verification status
• /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
• /regenerate-welcome - Regenerate this welcome message
• /security-override - Set security check runs to pass (maintainers only)
• /security-override cancel - Re-run security checks

Review & Approval

• /lgtm - Approve changes (looks good to me)
• /approve - Approve PR (approvers only)
• /assign-reviewers - Assign reviewers based on OWNERS file
• /assign-reviewer @username - Assign specific reviewer
• /check-can-merge - Check if PR meets merge requirements

Testing & Validation

• /retest tox - Run Python test suite with tox
• /retest build-container - Rebuild and test container image
• /retest verify-bugs-are-open - verify-bugs-are-open
• /retest all - Run all available tests

Container Operations

• /build-and-push-container - Build and push container image (tagged with PR number)
  • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

• /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
  • Multiple branches: /cherry-pick branch1 branch2 branch3
• /cherry-pick-retry <branch> - Retry a failed cherry-pick (merged PRs only)

Branch Management

• /rebase - Rebase this PR branch onto its base branch

Label Management

• /<label-name> - Add a label to the PR
• /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

1. Approval: /approve from at least one approver
2. LGTM Count: Minimum 2 /lgtm from reviewers
3. Status Checks: All required status checks must pass
4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

• dshchedr
• myakove
• rnetser
• vsibirsk

Reviewers:

• OhadRevah
• RoniKishner
• albarker-rh
• dshchedr
• hmeir
• rlobillo
• rnetser
• vsibirsk

Available Labels

• hold
• verified
• wip
• lgtm
• approve

AI Features

• Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6-1m)

Security Checks

• Suspicious Path Detection: Monitors paths: .claude/, .vscode/, .cursor/, .devcontainer/, .pi/, .github/workflows/, .github/actions/
• Committer Identity Check: Verifies last committer matches PR author
• Mandatory: Security checks block merge (use /security-override to bypass — maintainers only)

💡 Tips

• WIP Status: Use /wip when your PR is not ready for review
• Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
• Cherry-picking: Cherry-pick labels are processed when the PR is merged
• Container Builds: Container images are automatically tagged with the PR number
• Permission Levels: Some commands require approver permissions
• Auto-verified Users: Certain users have automatic verification and merge privileges

📌 Additional Information

Custom Commands:

• /test-plan — Triggers CodeRabbit to analyze the PR's changed files and post a test execution plan
• /rerun-smoke — Adds retest-smoke label on the PR to trigger smoke tests execution

For more information, please refer to the project documentation or contact the maintainers.

[rlobillo]

/lgtm

[OhadRevah]

/cherry-pick cnv-4.22 cnv-4.21 cnv-4.20 cnv-4.19 cnv-4.18

[openshift-virtualization-qe-bot-6]

Cherry-pick conflicts were resolved by AI

Cherry-picked PR Remove redundant and duplicated by upstream t2 tests into cnv-4.19: #5928
Conflicts were automatically resolved by AI (claude/claude-opus-4-6-1m).

@OhadRevah Manual verification is required — please review the changes and test before merging.

[openshift-virtualization-qe-bot-6]

Cherry-picked PR Remove redundant and duplicated by upstream t2 tests into cnv-4.21: #5930

[openshift-virtualization-qe-bot-6]

Cherry-pick conflicts were resolved by AI

Cherry-picked PR Remove redundant and duplicated by upstream t2 tests into cnv-4.20: #5931
Conflicts were automatically resolved by AI (claude/claude-opus-4-6-1m).

@OhadRevah Manual verification is required — please review the changes and test before merging.

[openshift-virtualization-qe-bot-6]

Cherry-pick conflicts were resolved by AI

Cherry-picked PR Remove redundant and duplicated by upstream t2 tests into cnv-4.18: #5932
Conflicts were automatically resolved by AI (claude/claude-opus-4-6-1m).

@OhadRevah Manual verification is required — please review the changes and test before merging.

[openshift-virtualization-qe-bot-6]

Cherry-picked PR Remove redundant and duplicated by upstream t2 tests into cnv-4.22: #5933

[openshift-virtualization-qe-bot]

New container for quay.io/openshift-cnv/openshift-virtualization-tests:latest published

[OhadRevah]

/cherry-pick cnv-4.20

[openshift-virtualization-qe-bot-2]

Cherry-pick label already present for: cnv-4.20
To re-trigger, remove the cherry-pick label(s) and run the command again.

[OhadRevah]

/cherry-pick cnv-4.20

[openshift-virtualization-qe-bot-2]

Cherry-pick conflicts were resolved by AI

Cherry-picked PR Remove redundant and duplicated by upstream t2 tests into cnv-4.20: #5962
Conflicts were automatically resolved by AI (claude/claude-opus-4-6-1m).

@OhadRevah Manual verification is required — please review the changes and test before merging.