Skip to content

fix(select): default selected options #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cdcabrera wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(select): default selected options #1690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions src/common/__tests__/__snapshots__/dateHelpers.test.js.snap
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/common/dateHelpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ const getRangedMonthDateTime = (month, defaultLocale = helpers.UI_LOCALE_DEFAULT

while (endDateUpdated > startDateUpdated || startDateUpdated.getUTCMonth() === endDateUpdated.getUTCMonth()) {
const dateTime = {
startDateString: setStartOfDay(startDateUpdated).toISOString(),
value: {
startDate: new Date(setStartOfDay(startDateUpdated))
}
Expand All @@ -210,6 +211,7 @@ const getRangedMonthDateTime = (month, defaultLocale = helpers.UI_LOCALE_DEFAULT
const isNextYear = currentYear !== startDateUpdated.getUTCFullYear();
dateTime.title = (isNextYear && titleYear) || title;
dateTime._title = title.toLowerCase();
dateTime.endDateString = setEndOfMonth(startDateUpdated).toISOString();
dateTime.value.endDate = setEndOfMonth(startDateUpdated);

startDateUpdated.setUTCMonth(startDateUpdated.getUTCMonth() + 1);
Expand Down
20 changes: 10 additions & 10 deletions src/components/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,8 +1465,8 @@ A bundled wrapper for PF Select, Dropdown.
* [.memo](#Form.module_Select..updateOptions.memo)
* [~updateSelectedOptions(options)](#Form.module_Select..updateSelectedOptions) ⇒ <code>Array</code> \| <code>Array.&lt;(&quot;NaN&quot;\|&quot;null&quot;\|unknown)&gt;</code>
* [.memo](#Form.module_Select..updateSelectedOptions.memo)
* [~updateSelectedProp(params)](#Form.module_Select..updateSelectedProp) ⇒ <code>Object</code> \| <code>undefined</code> \| <code>Array.&lt;{isSelected:boolean}&gt;</code> \| <code>Array</code>
* [.memo](#Form.module_Select..updateSelectedProp.memo)
* [~updateOptionsSelectedOptions(params)](#Form.module_Select..updateOptionsSelectedOptions) ⇒ <code>Object</code> \| <code>undefined</code> \| <code>Array.&lt;{isSelected:boolean}&gt;</code> \| <code>Array</code>
* [.memo](#Form.module_Select..updateOptionsSelectedOptions.memo)
* [~formatEvent(params)](#Form.module_Select..formatEvent) ⇒ <code>CustomEvent.&lt;{keyCode, currentTarget: {}, name, checked: \*, id: \*, persist: function(), value, target: {}, selected: (unknown\|Array.&lt;unknown&gt;), selectedIndex: Array.&lt;number&gt;, type: (&quot;select-one&quot;\|&quot;select-multiple&quot;), value: unknown}&gt;</code>
* [~setSelectElements([variant])](#Form.module_Select..setSelectElements) ⇒ <code>Object</code>
* [.memo](#Form.module_Select..setSelectElements.memo)
Expand Down Expand Up @@ -1567,9 +1567,9 @@ Update selected list options for consumption.
A memoized response for the updateSelectedOptions function. Assigned to a property for testing function.

**Kind**: static property of [<code>updateSelectedOptions</code>](#Form.module_Select..updateSelectedOptions)
<a name="Form.module_Select..updateSelectedProp"></a>
<a name="Form.module_Select..updateOptionsSelectedOptions"></a>

### Select~updateSelectedProp(params) ⇒ <code>Object</code> \| <code>undefined</code> \| <code>Array.&lt;{isSelected:boolean}&gt;</code> \| <code>Array</code>
### Select~updateOptionsSelectedOptions(params) ⇒ <code>Object</code> \| <code>undefined</code> \| <code>Array.&lt;{isSelected:boolean}&gt;</code> \| <code>Array</code>
Update the isSelected property for formatted options.

**Kind**: inner method of [<code>Select</code>](#Form.module_Select)
Expand All @@ -1591,16 +1591,16 @@ Update the isSelected property for formatted options.
</tr> </tbody>
</table>

<a name="Form.module_Select..updateSelectedProp.memo"></a>
<a name="Form.module_Select..updateOptionsSelectedOptions.memo"></a>

#### updateSelectedProp.memo
A memoized response for the updateSelectedProp function. Assigned to a property for testing function.
#### updateOptionsSelectedOptions.memo
A memoized response for the updateOptionsSelectedOptions function. Assigned to a property for testing function.

**Kind**: static property of [<code>updateSelectedProp</code>](#Form.module_Select..updateSelectedProp)
**Kind**: static property of [<code>updateOptionsSelectedOptions</code>](#Form.module_Select..updateOptionsSelectedOptions)
<a name="Form.module_Select..formatEvent"></a>

### Select~formatEvent(params) ⇒ <code>CustomEvent.&lt;{keyCode, currentTarget: {}, name, checked: \*, id: \*, persist: function(), value, target: {}, selected: (unknown\|Array.&lt;unknown&gt;), selectedIndex: Array.&lt;number&gt;, type: (&quot;select-one&quot;\|&quot;select-multiple&quot;), value: unknown}&gt;</code>
Expand returned event for select responses.
Expand the returned event for select responses.

**Kind**: inner method of [<code>Select</code>](#Form.module_Select)
<table>
Expand Down Expand Up @@ -6907,7 +6907,7 @@ On select update category.
<a name="Toolbar.module_ToolbarFieldSelectCategory..useSelectCategoryOptions"></a>

### ToolbarFieldSelectCategory~useSelectCategoryOptions(options) ⇒ <code>Object</code>
Return filtered category options, current, and initial value.
Return filtered configured category options, current, and initial value.

**Kind**: inner method of [<code>ToolbarFieldSelectCategory</code>](#Toolbar.module_ToolbarFieldSelectCategory)
<table>
Expand Down
Loading
Loading