Skip to content

fix(select): default selected options - #1690

Draft
cdcabrera wants to merge 1 commit into
RedHatInsights:mainfrom
cdcabrera:202508-select-fix
Draft

fix(select): default selected options#1690
cdcabrera wants to merge 1 commit into
RedHatInsights:mainfrom
cdcabrera:202508-select-fix

Conversation

@cdcabrera

@cdcabrera cdcabrera commented Aug 26, 2025

Copy link
Copy Markdown
Member

What's included

  • fix(select): default selected options

Notes

  • long-standing issue that has carried over between multiple iterations of the component. helped by resolving the additional fixes for useReactRedux and dateHelpers meta properties
  • refactor select so it uses the "selected options" prop as originally intended.
    • currently the selected options based on configuration have to be set via the options prop and the isSelected property. this refactor offsets that responsibility onto the select component via the "selected options".

How to test

Example

...

Updates issue/story

@codecov-commenter

codecov-commenter commented Aug 26, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.28%. Comparing base (39fcdf1) to head (6d36fc8).
⚠️ Report is 46 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1690      +/-   ##
==========================================
+ Coverage   91.26%   91.28%   +0.01%     
==========================================
  Files         125      125              
  Lines        5187     5184       -3     
  Branches     2402     2402              
==========================================
- Hits         4734     4732       -2     
+ Misses        417      416       -1     
  Partials       36       36              
Files with missing lines Coverage Δ
src/common/dateHelpers.js 93.33% <100.00%> (+0.09%) ⬆️
src/components/form/select.js 98.19% <100.00%> (+0.11%) ⬆️
...c/components/toolbar/toolbarFieldBillingAccount.js 97.67% <100.00%> (-0.06%) ⬇️
.../components/toolbar/toolbarFieldBillingProvider.js 100.00% <ø> (ø)
src/components/toolbar/toolbarFieldCategory.js 100.00% <ø> (ø)
src/components/toolbar/toolbarFieldGranularity.js 100.00% <ø> (ø)
src/components/toolbar/toolbarFieldGroupVariant.js 100.00% <100.00%> (ø)
...rc/components/toolbar/toolbarFieldRangedMonthly.js 100.00% <ø> (ø)
...c/components/toolbar/toolbarFieldSelectCategory.js 69.09% <ø> (-0.56%) ⬇️
src/components/toolbar/toolbarFieldSla.js 100.00% <ø> (ø)
... and 2 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fcdf1...6d36fc8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants