refactor: drop the tutorial and language entry points and pin the app to pt - #699
Closed
ErickMascarenhas wants to merge 1 commit into
Closed
refactor: drop the tutorial and language entry points and pin the app to pt#699ErickMascarenhas wants to merge 1 commit into
ErickMascarenhas wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
Summary
features/tutorialcontinuam no código, apenas sem ponto de entrada na interface.I18nProvidernão consulta mais o idioma do aparelho nem a preferência salva, então quem já tinha escolhido inglês volta para o português.t()intactos, de modo que reativar o seletor é só reintroduzir o estado de preferência no provider.LOCALE_OPTIONS, as chavessettings.language*,settings.tutorial,settings.openTutorialesettings.showTutorialButton*(estas duas já não eram usadas), e oallCompleteddo contexto de tutorial, que só existia para o atalho do cabeçalho.Header, doI18nProvider, doTutorialProvidere daTutorialModuleScreen, que descreviam o atalho removido.Validation:
npx tsc --noEmit— 0 erros.npm run lint— 0 erros (7 warnings pré-existentes, nenhum novo).npx typedoc@0.28.19— gerado sem avisos.preference/setPreference/LOCALE_OPTIONSnão tinham nenhum outro consumidor além da tela de Configurações, e quelocale(usado porlocalizeFormText) segue exposto.