Repository navigation
Rename the fpv variant wfbng, after the wfb-ng it carries - #184
Conversation
PR Summary by QodoRename the wfb-ng FPV variant to wfbng while preserving upgrade URLs
AI Description
Diagram
High-Level Assessment
Files changed (54)
|
Code Review by Qodo
1. Builds without the renamed variant fail
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
"fpv" says what the build is for, not what is in it, and three of the four FPV builds here are FPV too: rubyfpv and apfpv replace wfb-ng, and the coming waybeam build keeps it with another encoder. The wfb-ng air unit becomes wfbng (OpenIPC/website#390): every *_fpv defconfig, device directory and excludes list, BR2_OPENIPC_VARIANT, the device customizers' upgrade URLs, the CI smoke targets, the drift map and the tests. The kernel configs (*.generic-fpv.config) are internal and keep their names. BR2_OPENIPC_MAJESTIC="fpv" is majestic's own build and stays. Cameras already in the field keep asking for the fpv names: the generic ones by BUILD_OPTION, the devices by the upgrade URL their customizer wrote into the bootloader environment once, which an upgrade keeps. So latest also gets every wfbng image under its fpv name, with no end date. Needs OpenIPC/firmware#2548 (firmware branches on the variant name in four places) and OpenIPC/majestic-webui#640 (updatewebui) first.
25788d5 to
60326b0
Compare
1 participant
fpvsays what a build is for, not what is in it, and it isn't the only FPV build here:rubyfpvandapfpvreplace wfb-ng, and the comingwaybeambuild keeps wfb-ng with another encoder. The wfb-ng air unit becomeswfbng. Context: OpenIPC/website#390. The site already offers these builds in its installer, accepting either name (OpenIPC/website#404).Merge after OpenIPC/firmware#2548 and OpenIPC/majestic-webui#640. Firmware branches on the variant name in four places (the WebUI FPV fixup, the hi3516ev200/gk7205v200 FPV sensor set, the rtl8733bu
_fpvdriver branch, the legacy telemetry), andupdatewebuiin one. builder.sh clones firmware at HEAD.What changes
BR2_OPENIPC_VARIANT="wfbng", file names*_fpv*→*_wfbng*.ssc338q_fpv_<board>→ssc338q_wfbng_<board>(6), plusssc377qe_wfbng_ccdcam-im50q01-tipomanandgk7205v200_wfbng_8812eu.<soc>_fpv.list→<soc>_wfbng.list.rootfs_script.shpicks them as${SOC}_${VARIANT}.list.upgradeURLs point at the new names.ci-matrix.pysmoke targets and cases,firmware-drift.jsonpaths, the drift checker's and push tests,enrich_manifest.pydocs, CLAUDE.md.*.generic-fpv.configkernel configs (internal, keeps the drift map stable), andBR2_OPENIPC_MAJESTIC="fpv"(Majestic's own build flavour, not the variant).Cameras in the field
Cameras flashed before the rename keep asking
latestfor the old names:openipc.<soc>-<flash>-fpv.tgzfromBUILD_OPTION.upgradeURL their customizer wrote into the bootloader environment.S30customizerruns once, and an upgrade keeps the overlay, so that URL never changes by itself.So the publish job also uploads every
wfbngimage tolatestunder itsfpvname (openipc.<soc>-<flash>-fpv.tgz,<soc>_fpv_<board>-<flash>.tgz), with no end date. A device camera would otherwise silently stop getting updates. A generic camera reportswfbngafter one upgrade. Dated and nightly releases carry only the new names.Checked locally
ci-matrix.py --self-test: 126 devices, 15 smoke targets.check-firmware-drift.py --self-test.lint-workflow-shell.py(+ self-test),lint-cli-paths.py(+ self-test),test_push_build.py.