Skip to content

fix(dev): stop a trailing comment becoming the RabbitMQ hostname (#7644) #7645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sandy Ghs (sandyghs) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(dev): stop a trailing comment becoming the RabbitMQ hostname (#7644) #7645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5eaa70
fix(dev): stop a trailing comment becoming the RabbitMQ hostname
sandyghs Aug 28, 2026
e1b12a4
fix(dev): keep host.docker.internal as the default, note above the value
sandyghs Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions fds-migration/reports/conformity-latest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,96 @@
{
"generatedAt": "2026-08-23T10:27:28.468Z",
"results": [
{
"check": "bridge-integrity",
"file": "src/components/fds-tokens.generated.ts",
"status": "OK"
},
{
"check": "bridge-freshness",
"file": "src/components/fds-tokens.generated.ts",
"status": "SKIPPED",
"detail": "filigran-design-system not checked out as a sibling repo — can't compare theme.css"
},
{
"check": "wiring",
"file": "openaev-front/src/components/ThemeDark.ts",
"status": "OK"
},
{
"check": "wiring",
"file": "openaev-front/src/components/ThemeLight.ts",
"status": "OK"
},
{
"check": "forbidden-pattern",
"file": "openaev-front/src/components/ThemeDark.ts",
"status": "OK"
},
{
"check": "forbidden-pattern",
"file": "openaev-front/src/components/ThemeDark.ts",
"status": "OK"
},
{
"check": "forbidden-pattern",
"file": "openaev-front/src/components/ThemeDark.ts",
"status": "OK"
},
{
"check": "forbidden-pattern",
"file": "openaev-front/src/components/ThemeDark.ts",
"status": "OK"
},
{
"check": "forbidden-pattern",
"file": "openaev-front/src/components/ThemeLight.ts",
"status": "OK"
},
{
"check": "forbidden-pattern",
"file": "openaev-front/src/components/ThemeLight.ts",
"status": "OK"
},
{
"check": "forbidden-pattern",
"file": "openaev-front/src/components/ThemeLight.ts",
"status": "OK"
},
{
"check": "forbidden-pattern",
"file": "openaev-front/src/components/ThemeLight.ts",
"status": "OK"
},
{
"check": "lib-component-usage",
"file": "openaev-front/src/admin/components/common/ConfigurationSection.tsx",
"status": "OK"
},
{
"check": "lib-component-usage",
"file": "openaev-front/src/admin/components/lessons/simulations/LessonsCategories.jsx",
"status": "OK"
},
{
"check": "lib-component-usage",
"file": "openaev-front/src/admin/components/lessons/simulations/Lessons.tsx",
"status": "OK"
},
{
"check": "lib-component-usage",
"file": "openaev-front/src/admin/components/lessons/scenarios/LessonsCategories.jsx",
"status": "OK"
},
{
"check": "lib-component-usage",
"file": "openaev-front/src/admin/components/lessons/scenarios/Lessons.tsx",
"status": "OK"
},
{
"check": "lib-component-usage",
"file": "openaev-front/src/components/common/detail/EntityDetailCommon.tsx",
"status": "OK"
}
]
}
6 changes: 5 additions & 1 deletion openaev-api/src/main/resources/application-dev.properties.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,11 @@ executor.openaev.binaries.version=prerelease
# INJECTORS #
#############
openaev.rabbitmq.prefix=openaev
openaev.rabbitmq.hostname=host.docker.internal # you can also set it to localhost, but in case you wish to have injectors installed locally through your docker containers, you must use host.docker.internal instead and then point this domain to 127.0.0.1 in your /etc/hosts
# Keep host.docker.internal so injectors and collectors running in Docker can
# reach the broker. It does not resolve from the host itself, so a backend run
# outside Docker needs it pointed at 127.0.0.1 in /etc/hosts (or set to
# localhost, which drops those injectors).
openaev.rabbitmq.hostname=host.docker.internal
openaev.rabbitmq.user=guest
openaev.rabbitmq.pass=guest
openaev.rabbitmq.queue-type=classic
Expand Down
Loading