fix(dev): stop a trailing comment becoming the RabbitMQ hostname (#7644) - #7645
Open
Sandy Ghs (sandyghs) wants to merge 2 commits into
Open
fix(dev): stop a trailing comment becoming the RabbitMQ hostname (#7644)#7645Sandy Ghs (sandyghs) wants to merge 2 commits into
Sandy Ghs (sandyghs) wants to merge 2 commits into
Conversation
`.properties` only treats `#` as a comment at the start of a line, so the note after the value was parsed as part of it and the backend died on startup with `UnknownHostException: host.docker.internal # you can also set it to ...`. README step 2 tells a new developer to copy this file verbatim, so every fresh environment hits it. The note moves above the property. Closes #7644 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
📖 Documentation check — ✅ Passed 1 functional file(s), 0 doc file(s) changed. No documentation gaps detected. |
Filigran Automation (Filigran-Automation)
added
the
filigran team
Romuald Lemesle (RomuDeuxfois)
requested changes
Aug 28, 2026
| # Set to localhost for a plain local run. Use host.docker.internal if you want | ||
| # injectors installed locally through your Docker containers to reach the broker; | ||
| # in that case, point that name at 127.0.0.1 in your /etc/hosts. | ||
| openaev.rabbitmq.hostname=localhost |
There was a problem hiding this comment.
Developers run OpenAEV with injectors and collectors most of the time so having host.docker.internal in the first place make more sense.
Author
There was a problem hiding this comment.
Done — host.docker.internal is back as the default, and the fix now only targets the real bug
Review asks for host.docker.internal in first place, since developers usually run with injectors and collectors. The defect this PR fixes is the trailing comment, not the value, so the value goes back and the note moves above it. The note now states the condition explicitly: the name does not resolve from the host, so a backend run outside Docker needs it in /etc/hosts. Measured on a clean macOS host — no /etc/hosts entry, DNS resolution fails — which is what made the original one-line form fatal rather than merely wrong. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Romuald Lemesle (RomuDeuxfois)
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.propertiesonly treats#as a comment at the start of a line, so the note written after the value was parsed as part of it. A backend started from a fresh copy of this example dies with:README step 2 tells a new developer to copy this file verbatim, so every fresh environment hits it. The note moves above the property, and the value becomes
localhost— the plain local run the README's minimal start describes.Found while standing up a dev environment from scratch. Scanned the other
*.properties.examplefiles for the same shape: this was the only one.Closes #7644