[19.0][FIX] website_sale_product_minimal_price: crash on shop with lazy request.pricelist (Odoo 19)

[antoineAkyado]

Bug

On the eCommerce shop page, computing the cheapest variant of a product crashes with:

AttributeError: 'product.pricelist' object has no attribute '__ior__'

Traceback

File ".../website_sale/controllers/main.py", line 458, in shop
    variants = request.env['product.product'].sudo().browse(product._get_first_possible_variant_id() for product in products)
File ".../website_sale_product_minimal_price/models/product_template.py", line 111, in _get_first_possible_combination
    product = self._get_cheapest_info(pricelist)[0]
File ".../website_sale_product_minimal_price/models/product_template.py", line 72, in _get_cheapest_info
    variant_items = self._get_pricelist_variant_items(pricelist)
File ".../website_sale_product_minimal_price/models/product_template.py", line 55, in _get_pricelist_variant_items
    visited_pricelists |= pricelist
File ".../odoo/tools/func.py", line 235, in __ior__
    def __ior__(self, other): return self._value.__ior__(other)
AttributeError: 'product.pricelist' object has no attribute '__ior__'

Root cause

Two Odoo 19 changes combine to trigger this:

1. request.pricelist is now a lazy() proxy — website_sale/models/ir_http.py:

   request.pricelist = lazy(request.website._get_and_cache_current_pricelist)

   _get_website_current_pricelist() returns it as-is.
2. Recordsets no longer implement in-place set operators — BaseModel defines __or__ but not __ior__. For a plain recordset, x |= y falls back to __or__ (fine). For a lazy, lazy.__ior__ (in odoo/tools/func.py) delegates to product.pricelist.__ior__, which no longer exists -> AttributeError.

_get_pricelist_variant_items() does visited_pricelists |= pricelist, where visited_pricelists was initialised from the lazy request.pricelist.

How to reproduce

• A product with more than one variant (product_variant_count > 1).
• A pricelist with sub-pricelists (items with compute_price = 'formula', base = 'pricelist', base_pricelist_id set), so the while next_pricelists: loop actually runs and reaches visited_pricelists |= pricelist.
• Open the shop page -> crash. (A flat pricelist never enters the loop, which is why it is not hit by everyone.)

Fix

_get_website_current_pricelist now materialises the pricelist into a real recordset, so downstream in-place set operations keep working. The existing test is updated to reproduce the lazy scenario as a regression test.

[OCA-git-bot]

Hi @sergio-teruel,
some modules you are maintaining are being modified, check this out!

[pedrobaeza]

Please don't add this. It's not adding value to the user documentation. The commit message already serves for devs discovering purposes.

[pedrobaeza]

Don't change manually the module version. It will be done on merge by the bot.

[antoineAkyado]

Ho sorry, i change for my développement.
i remember for the next update thk ;-)

[pedrobaeza]

Please undo it here.

[pedrobaeza]

And squashing the result