Skip to content

[19.0][FIX] website_sale_product_minimal_price: Fix price scale rendering, currency and shop crash - #1300

Open
cristina-hidalgo-tecnativa wants to merge 3 commits into
OCA:19.0from
Tecnativa:19.0-fix-website_sale_product_minimal_price-price_scale_currency
Open

[19.0][FIX] website_sale_product_minimal_price: Fix price scale rendering, currency and shop crash#1300
cristina-hidalgo-tecnativa wants to merge 3 commits into
OCA:19.0from
Tecnativa:19.0-fix-website_sale_product_minimal_price-price_scale_currency

Conversation

@cristina-hidalgo-tecnativa

Copy link
Copy Markdown
Contributor

Fixes three v19 regressions in the price scale feature:

  • Rendering: the VariantMixin._onChangeCombination monkey-patch is orphaned since core now copies it into WebsiteSale.prototype via Object.assign at import time. Switched to patch(WebsiteSale.prototype, {...}), and fixed the form selector/insertion point (the <form> has no action anymore and Terms/shipping/accordion now live inside it too).
  • Currency: the price scale used product.currency_id instead of the pricelist's currency, causing a mismatch between the amount and its symbol.
  • Crash: /shop raised AttributeError with chained sub-pricelists because request.pricelist (a lazy wrapper in core) doesn't support |=.

@Tecnativa TT64164
@pedrobaeza @pilarvargas-tecnativa

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @sergio-teruel,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot OCA-git-bot added series:19.0 mod:website_sale_product_minimal_price Module website_sale_product_minimal_price labels Aug 21, 2026
@pedrobaeza

Copy link
Copy Markdown
Member

Please remove the patch that is in #1273 (or use temporary reference if needed, but not to hard-copy it), and for the rest, please add an explanation of the what and why in the commit message itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:website_sale_product_minimal_price Module website_sale_product_minimal_price series:19.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants