[19.0][FIX] website_sale_product_minimal_price: Fix price scale rendering, currency and shop crash - #1300
Open
cristina-hidalgo-tecnativa wants to merge 3 commits into
Conversation
Contributor
|
Hi @sergio-teruel, |
Member
|
Please remove the patch that is in #1273 (or use temporary reference if needed, but not to hard-copy it), and for the rest, please add an explanation of the what and why in the commit message itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three v19 regressions in the price scale feature:
VariantMixin._onChangeCombinationmonkey-patch is orphaned since core now copies it intoWebsiteSale.prototypeviaObject.assignat import time. Switched topatch(WebsiteSale.prototype, {...}), and fixed the form selector/insertion point (the<form>has noactionanymore and Terms/shipping/accordion now live inside it too).product.currency_idinstead of the pricelist's currency, causing a mismatch between the amount and its symbol./shopraisedAttributeErrorwith chained sub-pricelists becauserequest.pricelist(a lazy wrapper in core) doesn't support|=.@Tecnativa TT64164
@pedrobaeza @pilarvargas-tecnativa